Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: replace the btree library for v2 implementation #58466

Merged
merged 5 commits into from
Dec 24, 2024

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Dec 23, 2024

What problem does this PR solve?

Issue Number: close #58363

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. No logic change, just replace a library.

  2. Checked with WITH_RACE=1 make, no data race found

  3. Re-test the issue loadInfoSchema() slow when there are background query visiting INFORMATION_SCHEMA.TABLES #58363, now loadSchemaDiff is fast enough, and stable.

image

  1. Mutex on infoschema v2 is gone:

go tool pprof -http=:6061 'http://127.0.0.1:10080/debug/pprof/mutex

image

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 23, 2024
Copy link

tiprow bot commented Dec 23, 2024

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 97.22222% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.1001%. Comparing base (14a469a) to head (db788d5).
Report is 10 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58466        +/-   ##
================================================
+ Coverage   73.5275%   75.1001%   +1.5725%     
================================================
  Files          1681       1726        +45     
  Lines        464109     473733      +9624     
================================================
+ Hits         341248     355774     +14526     
+ Misses       102032      95756      -6276     
- Partials      20829      22203      +1374     
Flag Coverage Δ
integration 49.2580% <90.2777%> (?)
unit 72.4987% <97.2222%> (+0.2096%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 61.9323% <ø> (+16.1597%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 24, 2024
Copy link

ti-chi-bot bot commented Dec 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 24, 2024
Copy link

ti-chi-bot bot commented Dec 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-24 02:52:34.616144517 +0000 UTC m=+1530144.704947057: ☑️ agreed by lance6716.
  • 2024-12-24 07:58:17.38958476 +0000 UTC m=+1548487.478387303: ☑️ agreed by wjhuang2016.

@tiancaiamao
Copy link
Contributor Author

/test pull-br-integration-test

Copy link

tiprow bot commented Dec 24, 2024

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit e403d8f into pingcap:master Dec 24, 2024
26 checks passed
@tiancaiamao tiancaiamao deleted the replace-btree branch December 24, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loadInfoSchema() slow when there are background query visiting INFORMATION_SCHEMA.TABLES
3 participants