-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema: replace the btree library for v2 implementation #58466
Conversation
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58466 +/- ##
================================================
+ Coverage 73.5275% 75.1001% +1.5725%
================================================
Files 1681 1726 +45
Lines 464109 473733 +9624
================================================
+ Hits 341248 355774 +14526
+ Misses 102032 95756 -6276
- Partials 20829 22203 +1374
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/test pull-br-integration-test |
@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: close #58363
Problem Summary:
What changed and how does it work?
Check List
Tests
No logic change, just replace a library.
Checked with
WITH_RACE=1 make
, no data race foundRe-test the issue loadInfoSchema() slow when there are background query visiting INFORMATION_SCHEMA.TABLES #58363, now loadSchemaDiff is fast enough, and stable.
go tool pprof -http=:6061 'http://127.0.0.1:10080/debug/pprof/mutex
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.