Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade the PD client to adopt the latest refactor #58440

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #58439.

Problem Summary:

Upgrade the PD client to adopt the latest refactor.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. component/dumpling This is related to Dumpling of TiDB. labels Dec 20, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 23, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 23, 2024
@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 23, 2024
Copy link

ti-chi-bot bot commented Dec 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-23 06:44:16.60008954 +0000 UTC m=+1457646.688892082: ☑️ agreed by lance6716.
  • 2024-12-23 06:56:16.887650588 +0000 UTC m=+1458366.976453131: ☑️ agreed by YuJuncen.

@JmPotato JmPotato force-pushed the update_pd_client branch 2 times, most recently from b50eea9 to 1cc91af Compare December 23, 2024 07:23
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 62.88660% with 36 lines in your changes missing coverage. Please review.

Project coverage is 75.0498%. Comparing base (ef7ade7) to head (2ca052e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58440        +/-   ##
================================================
+ Coverage   73.5359%   75.0498%   +1.5139%     
================================================
  Files          1681       1726        +45     
  Lines        464055     472763      +8708     
================================================
+ Hits         341247     354808     +13561     
+ Misses       101997      95775      -6222     
- Partials      20811      22180      +1369     
Flag Coverage Δ
integration 49.1579% <34.3750%> (?)
unit 72.4704% <54.7368%> (+0.1722%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <0.0000%> (ø)
parser ∅ <ø> (∅)
br 61.7100% <72.0000%> (+15.9433%) ⬆️

@JmPotato
Copy link
Member Author

/test build

Copy link

tiprow bot commented Dec 23, 2024

@JmPotato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test fast_test_tiprow_ddlargsv1
  • /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

  • fast_test_tiprow
  • tidb_parser_test

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 14a469a into pingcap:master Dec 23, 2024
32 checks passed
@JmPotato JmPotato deleted the update_pd_client branch December 23, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/dumpling This is related to Dumpling of TiDB. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants