br/stream: allow pitr to create oversized indices #58433
Conversation
Signed-off-by: hillium <[email protected]>
ti-chi-bot
bot
added
do-not-merge/invalid-title
release-note
|
Hi @YuJuncen. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
YuJuncen
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #58433 +/- ##
================================================
+ Coverage 73.5696% 74.0560% +0.4863%
================================================
Files 1681 1762 +81
Lines 463846 543144 +79298
================================================
+ Hits 341250 402231 +60981
- Misses 101779 117269 +15490
- Partials 20817 23644 +2827
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…r-restore-indices
Signed-off-by: hillium <[email protected]>
|
1 similar comment
|
/test pull-br-integration-test |
|
@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
br/pkg/task/stream.go
Outdated
| @@ -1321,6 +1321,9 @@ func restoreStream( | |||
| ctx, cancelFn := context.WithCancel(c) | |||
| defer cancelFn() | |||
|
|
|||
| restoreCfg := enableTiDBConfig() | |||
There was a problem hiding this comment.
maybe let's put a comment here for what it's used for?
There was a problem hiding this comment.
I renamed the function. Perhaps its name now presents its intention properly?
|
@Tristan1900: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: hillium <[email protected]>
ti-chi-bot
bot
added
size/M
Signed-off-by: hillium <[email protected]>
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, BornChanger, Tristan1900 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
|
@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: close #58430
Problem Summary:
During restoring, the internal config of BR wasn't updated.
It may reject all indices longer than the default config (
3072) though the target cluster modified this config.What changed and how does it work?
This updates the TiDB config of the BR internal TiDB instance during restoring incremental data.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.