Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: remove dead code #58412

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Dec 19, 2024

Signed-off-by: Rustin170506 [email protected]

What problem does this PR solve?

Issue Number: ref #57804

Problem Summary:

What changed and how does it work?

In this PR, I removed the dead code. The stats loading for the PK, as shown, has never been executed, so it is safe to remove.

Some background:

  1. statistics: fix PK column TopN not loading when init stats #37552 This PR tried to load it correctly.
  2. statistics: fix wrong behavior for primary key' non-lite init stats #53298 This PR decided to remove it at all.
  3. Another fix based on the previous PR: *: not load unnecessay data during the non-lite-init-stats #53399
  4. Another full rewrite: statistics: correct behavior of non-lite InitStats and stats sync load of no stats column #57803

So we just forgot to delete it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2024
@Rustin170506 Rustin170506 added the skip-issue-check Indicates that a PR no need to check linked issue. label Dec 19, 2024
Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check (PR reviewed by myself and ready for feedback.)

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.8575%. Comparing base (05a35ca) to head (cca5abc).
Report is 7 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58412        +/-   ##
================================================
+ Coverage   73.5204%   73.8575%   +0.3370%     
================================================
  Files          1681       1711        +30     
  Lines        463800     472809      +9009     
================================================
+ Hits         340988     349205      +8217     
- Misses       101988     102137       +149     
- Partials      20824      21467       +643     
Flag Coverage Δ
integration 45.9932% <11.1111%> (?)
unit 72.4153% <88.8888%> (+0.1323%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7773% <ø> (+0.0059%) ⬆️

@Rustin170506
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 19, 2024
@Rustin170506
Copy link
Member Author

/retest

Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check (PR reviewed by myself and ready for feedback.)

@Rustin170506 Rustin170506 force-pushed the rustin-patch-dead-code branch from 1b3c08c to 57f5dd6 Compare December 20, 2024 04:06
Signed-off-by: Rustin170506 <[email protected]>
Signed-off-by: Rustin170506 <[email protected]>
Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check (PR reviewed by myself and ready for feedback.)

Copy link

ti-chi-bot bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 20, 2024
Copy link

ti-chi-bot bot commented Dec 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-19 09:02:07.847755663 +0000 UTC m=+1120317.936558206: ☑️ agreed by AilinKid.
  • 2024-12-20 08:05:47.90070758 +0000 UTC m=+1203337.989510169: ☑️ agreed by winoros.

@Rustin170506
Copy link
Member Author

/retest

@Rustin170506 Rustin170506 added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed skip-issue-check Indicates that a PR no need to check linked issue. labels Dec 20, 2024
@Rustin170506
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 0f0f708 into pingcap:master Dec 20, 2024
25 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #58442.

ti-chi-bot bot pushed a commit that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants