-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: add col/idx name(s) for BackfillProgressGauge and BackfillTotalCounter #58380
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58380 +/- ##
================================================
+ Coverage 73.1849% 74.9075% +1.7226%
================================================
Files 1681 1727 +46
Lines 463027 476996 +13969
================================================
+ Hits 338866 357306 +18440
+ Misses 103358 97417 -5941
- Partials 20803 22273 +1470
Flags with carried forward coverage won't be shown. Click here to find out more.
|
3e58c68
to
00ce588
Compare
00ce588
to
32bef79
Compare
/retest |
tidb_ddl_add_index_total
metricsf93556a
to
e098237
Compare
e098237
to
d548ded
Compare
6ea445b
to
5b8a111
Compare
/retest |
1 similar comment
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fzzf678, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@CbcWestwolf: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #58114
Problem Summary:
For BackfillProgressGauge and BackfillTotalCounter, tidb only shows the database name and table name in the metrics. If we add multiple indexes on a single table, it would be difficult to know the rate and progress of each index.
What changed and how does it work?
Check List
Tests
Test script:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.