-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: add more metrics for different operations of job execution, refine panels #58360
Conversation
Skipping CI for Draft Pull Request. |
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -351,11 +351,6 @@ func JobNeedGC(job *model.Job) bool { | |||
// finishDDLJob deletes the finished DDL job in the ddl queue and puts it to history queue. | |||
// If the DDL job need to handle in background, it will prepare a background job. | |||
func (w *worker) finishDDLJob(jobCtx *jobContext, job *model.Job) (err error) { | |||
startTime := time.Now() | |||
defer func() { | |||
metrics.DDLWorkerHistogram.WithLabelValues(metrics.WorkerFinishDDLJob, job.Type.String(), metrics.RetLabel(err)).Observe(time.Since(startTime).Seconds()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge into handle_job_done
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58360 +/- ##
================================================
+ Coverage 73.2226% 74.8506% +1.6279%
================================================
Files 1679 1727 +48
Lines 462548 477682 +15134
================================================
+ Hits 338690 357548 +18858
+ Misses 103086 97782 -5304
- Partials 20772 22352 +1580
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
@D3Hunter: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #54436
Problem Summary:
What changed and how does it work?
"Update Self Version Duration"
panel toSync Schema Version Operations Duration
backfill
/add-index
downavg
to some panel, and hide thep99
, it's more helpful to diagnose throughput issue using avg metricCheck List
Tests
after this PR, panels in
DDL
orders and shows in this way:Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.