Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: enable pd grpc client log #58339

Merged
merged 2 commits into from
Dec 20, 2024
Merged

lightning: enable pd grpc client log #58339

merged 2 commits into from
Dec 20, 2024

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Dec 17, 2024

What problem does this PR solve?

Issue Number: close #58337

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@okJiang
enable grpc client log
ce1c6bf 
Signed-off-by: okJiang <[email protected]>
@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 17, 2024
@okJiang okJiang changed the title lightning: enable grpc client log lightning: enable pd grpc client log Dec 17, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 17, 2024
lance6716
lance6716 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also keep an eye on PD client printing too much log after this change. For example, some ticker / retry are too short and in 1 ms multiple lines are printed

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 17, 2024
GMHDBJD
GMHDBJD approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 17, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-17 08:25:00.707012533 +0000 UTC m=+945290.795815200: ☑️ agreed by lance6716.
  • 2024-12-17 08:31:28.4303283 +0000 UTC m=+945678.519130842: ☑️ agreed by GMHDBJD.

@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.6320%. Comparing base (0ccee0e) to head (91b1239).
Report is 39 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58339        +/-   ##
================================================
+ Coverage   73.2102%   75.6320%   +2.4218%     
================================================
  Files          1679       1726        +47     
  Lines        462426     478334     +15908     
================================================
+ Hits         338543     361774     +23231     
+ Misses       103104      94571      -8533     
- Partials      20779      21989      +1210
Flag Coverage Δ
integration 49.8108% <100.0000%> (?)
unit 73.1486% <100.0000%> (+0.7961%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 62.1640% <ø> (+16.1379%) ⬆️

@okJiang
Copy link
Member Author

okJiang commented Dec 17, 2024

/test pull-lightning-integration-test

@tiprow tiprow
Copy link

tiprow bot commented Dec 17, 2024

@okJiang: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test fast_test_tiprow_ddlargsv1
  • /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

  • fast_test_tiprow
  • tidb_parser_test

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@okJiang
Copy link
Member Author

okJiang commented Dec 17, 2024

/retest

2 similar comments
@okJiang
Copy link
Member Author

okJiang commented Dec 17, 2024

/retest

@hawkingrei
Copy link
Member

/retest

@okJiang
fix it
91b1239 
Signed-off-by: okJiang <[email protected]>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@okJiang
Copy link
Member Author

okJiang commented Dec 18, 2024

/retest

8 similar comments
@okJiang
Copy link
Member Author

okJiang commented Dec 18, 2024

/retest

@okJiang
Copy link
Member Author

okJiang commented Dec 19, 2024

/retest

@okJiang
Copy link
Member Author

okJiang commented Dec 19, 2024

/retest

@okJiang
Copy link
Member Author

okJiang commented Dec 19, 2024

/retest

@okJiang
Copy link
Member Author

okJiang commented Dec 19, 2024

/retest

@okJiang
Copy link
Member Author

okJiang commented Dec 19, 2024

/retest

@okJiang
Copy link
Member Author

okJiang commented Dec 19, 2024

/retest

@okJiang
Copy link
Member Author

okJiang commented Dec 20, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 05a35ca into pingcap:master Dec 20, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pd grpc client logs can't show during lightning process
4 participants
@okJiang @hawkingrei @lance6716 @GMHDBJD