planner: extend predicate simplification for subquery and nested expressions | tidb-test=pr/2455 #58261

ghazalfamilyusa · 2024-12-13T22:57:50Z

What problem does this PR solve?

Issue Number: close #58171

Problem Summary:

The main problem can be explained by the example below. The query has a condition "True OR subquery" which can be simplified to True and therefore avoid the subquery execution.

SELECT 1 
FROM t1 AS tab 
WHERE 1 = 1 OR (EXISTS(SELECT  /*+ NO_DECORRELATE() */ 1 FROM t2 WHERE a2 = a1 ))

id      estRows task    access object   operator info
Projection      8000.00 root            1->Column#9
└─Selection     8000.00 root            or(1, Column#8)
 └─Apply       10000.00        root            CARTESIAN left outer semi join, left side:TableReader
   ├─TableReader(Build)        10000.00        root            data:TableFullScan
   │ └─TableFullScan   10000.00        cop[tikv]       table:tab       keep order:false, stats:pseudo
   └─TableReader(Probe)        100000.00       root            data:Selection
     └─Selection       100000.00       cop[tikv]               eq(test.t2.a2, test.t1.a1)
       └─TableFullScan 100000000.00    cop[tikv]       table:t2        keep order:false, stats:pseudo

The correct behaviour is this

id      estRows task    access object   operator info
Projection      10000.00        root            1->Column#9
└─TableReader   10000.00        root            data:TableFullScan
  └─TableFullScan       10000.00        cop[tikv]       table:tab       keep order:false, stats:pseudo

There are two problems that prevents the above optimizations:

Predicate simplification in TiDB optimizer does not cover all cases of True/False simplifications.
The subquery expression is rewritten to Apply operator early on during the AST to logical plan building and it is not possible for predicate simplification to undo that logic.

What changed and how does it work?

Changes are made to address both problems above by:

Extending Predicate Simplification rewrite to cover True/False logical simplifications for all expressions.
Remove subquery plan when the predicate is True by undoing the Apply operator. This logic is added to the decorrelation rewrite logic since it always process Apply and convert it to Join if it decides to decorrelate it.

Check List

Tests

Unit test
[] Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2024-12-13T22:58:08Z

Hi @ghazalfamilyusa. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2024-12-15T04:14:09Z

Codecov Report

Attention: Patch coverage is 92.70073% with 10 lines in your changes missing coverage. Please review.

Project coverage is 74.4914%. Comparing base (22c91d0) to head (5b06b96).
Report is 40 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #58261        +/-   ##
================================================
+ Coverage   73.2085%   74.4914%   +1.2829%     
================================================
  Files          1679       1686         +7     
  Lines        462531     471614      +9083     
================================================
+ Hits         338612     351312     +12700     
+ Misses       103136      99774      -3362     
+ Partials      20783      20528       -255

Flag	Coverage Δ
integration	`43.8426% <92.7007%> (?)`
unit	`73.2911% <79.5620%> (+0.9360%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.6910% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`46.0444% <ø> (+0.0454%)`	⬆️

ghazalfamilyusa · 2024-12-15T17:18:00Z

/test mysql-test

tiprow · 2024-12-15T17:18:21Z

@ghazalfamilyusa: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ghazalfamilyusa · 2024-12-16T19:23:24Z

/test check-dev2

tiprow · 2024-12-16T19:23:45Z

@ghazalfamilyusa: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hawkingrei · 2024-12-17T07:55:57Z

/ok-to-test

AilinKid · 2024-12-17T15:23:47Z

tests/integrationtest/t/planner/core/issuetest/planner_issue.test

@@ -11,7 +11,7 @@ CREATE TABLE aa311c3c (
 		KEY 464b386e (b80b3746),
 		KEY 19dc3c2d (57fd8d09)
 	      ) ENGINE=InnoDB DEFAULT CHARSET=ascii COLLATE=ascii_bin COMMENT='320f8401';
-explain select  /*+ use_index_merge( `aa311c3c` ) */   `aa311c3c`.`43b06e99` as r0 , `aa311c3c`.`6302d8ac` as r1 from `aa311c3c` where IsNull( `aa311c3c`.`b80b3746` ) or not( `aa311c3c`.`57fd8d09` >= '2008' )   order by r0,r1 limit 95;
+explain select  /*+ use_index_merge( `aa311c3c` ) */   `aa311c3c`.`43b06e99` as r0 , `aa311c3c`.`6302d8ac` as r1 from `aa311c3c` where `aa311c3c`.`b80b3746` = 3 or not( `aa311c3c`.`57fd8d09` >= '2008' )   order by r0,r1 limit 95;


what is change of the original test case for

tests/integrationtest/r/planner/core/casetest/physicalplantest/physical_plan.result

pkg/planner/core/rule_predicate_simplification.go

AilinKid · 2024-12-17T16:22:44Z

pkg/planner/core/rule_decorrelate.go

+	selectSource := logicalSelection.Children()[0]
+
+	// Check if the child is a LogicalApply
+	apply, ok := selectSource.(*logicalop.LogicalApply)


I'm afriad that this pattern is more tricky

tidb> explain select * from (select * from t where EXISTS(SELECT /*+ NO_DECORRELATE() */ 1 FROM t t2 WHERE t2.a = t.a)) s where 1 ; +-----------------------------+--------------+-----------+---------------+-----------------------------------------------+ | id | estRows | task | access object | operator info | +-----------------------------+--------------+-----------+---------------+-----------------------------------------------+ | Apply_12 | 10000.00 | root | | CARTESIAN semi join, left side:TableReader_14 | | ├─TableReader_14(Build) | 10000.00 | root | | data:TableFullScan_13 | | │ └─TableFullScan_13 | 10000.00 | cop[tikv] | table:t | keep order:false, stats:pseudo | | └─TableReader_17(Probe) | 100000.00 | root | | data:Selection_16 | | └─Selection_16 | 100000.00 | cop[tikv] | | eq(test.t.a, test.t.a) | | └─TableFullScan_15 | 100000000.00 | cop[tikv] | table:t2 | keep order:false, stats:pseudo | +-----------------------------+--------------+-----------+---------------+-----------------------------------------------+ 6 rows in set (0.01 sec)

in this case:
selection<1> which is finally removed, has a apply as its child, while we couldn't just let apply inner child to directly be the root here? cause the apply source is not comes from outer query block's where clause's scalar Exists, at which we thought Exists is same level with Where 1 here.
/cc @winoros

The test case you mentioned is the same as explain select * from t where EXISTS(SELECT /*+ NO_DECORRELATE() */ 1 FROM t t2 WHERE t2.a = t.a) and not sure if there is any splification that can be done. For additional safety, we check the pattern for outer join to make sure we do not remove the Apply (logical join) if it is inner join like the example shown. @AilinKid

AilinKid

for predicate simplification, it's a definite awesome to me

ghazalfamilyusa · 2024-12-17T19:12:34Z

/test fast_test_tiprow

ti-chi-bot · 2024-12-17T19:12:37Z

@ghazalfamilyusa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test pull-br-integration-test

/test pull-integration-ddl-test

/test pull-integration-e2e-test

/test pull-lightning-integration-test

/test pull-mysql-client-test

/test pull-unit-test-ddlv1

/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test

/test pull-common-test

/test pull-e2e-test

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-nodejs-test

/test pull-integration-python-orm-test

/test pull-sqllogic-test

/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build

pingcap/tidb/ghpr_check

pingcap/tidb/ghpr_check2

pingcap/tidb/ghpr_mysql_test

pingcap/tidb/ghpr_unit_test

pingcap/tidb/pull_integration_ddl_test

pingcap/tidb/pull_integration_e2e_test

pingcap/tidb/pull_mysql_client_test

In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2024-12-17T19:12:58Z

@ti-chi-bot[bot]: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddlargsv1
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

In response to this:

@ghazalfamilyusa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-sqllogic-test
/test pull-tiflash-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_mysql_client_test
In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ghazalfamilyusa · 2024-12-17T19:14:56Z

/test fast_test_tiprow

ti-chi-bot · 2024-12-17T19:15:00Z

@ghazalfamilyusa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test pull-br-integration-test

/test pull-integration-ddl-test

/test pull-integration-e2e-test

/test pull-lightning-integration-test

/test pull-mysql-client-test

/test pull-unit-test-ddlv1

/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test

/test pull-common-test

/test pull-e2e-test

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-nodejs-test

/test pull-integration-python-orm-test

/test pull-sqllogic-test

/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build

pingcap/tidb/ghpr_check

pingcap/tidb/ghpr_check2

pingcap/tidb/ghpr_mysql_test

pingcap/tidb/ghpr_unit_test

pingcap/tidb/pull_integration_ddl_test

pingcap/tidb/pull_integration_e2e_test

pingcap/tidb/pull_mysql_client_test

In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2024-12-17T19:15:21Z

@ti-chi-bot[bot]: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddlargsv1
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

In response to this:

@ghazalfamilyusa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-sqllogic-test
/test pull-tiflash-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_mysql_client_test
In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ghazalfamilyusa · 2024-12-17T19:17:37Z

/retest

…d AND/OR expressions with True/False values (2) Simplification of boolean expressions in subqueries

ghazalfamilyusa · 2024-12-17T21:39:03Z

/test check-dev2

tiprow · 2024-12-17T21:39:25Z

@ghazalfamilyusa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddlargsv1
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ghazalfamilyusa · 2024-12-19T02:40:07Z

/test check-dev2

tiprow · 2024-12-19T02:40:29Z

@ghazalfamilyusa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddlargsv1
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

AilinKid

rest lgtm

AilinKid · 2024-12-19T09:24:48Z

pkg/planner/core/rule_decorrelate.go

+
+	// Ensure the Apply operator is of a suitable join type to match the required pattern.
+	// Only LeftOuterJoin or LeftOuterSemiJoin are considered valid here.
+	if apply.JoinType != logicalop.LeftOuterJoin && apply.JoinType != logicalop.LeftOuterSemiJoin {


can we add one more line check here?
LeftOuter apply's schema.columns[len-1] (whichi is the scalar result output column) is in the selection's condition, which will make sure that the apply's scalar output is used just in the parent selection.

I think we can add a test to check it.
It should be like select ((1 = 1) or (exists(...)) from t. So, there'll be a final projection to project the result because the extra column of the semi-join only indicates whether the join result is matched or not.
Now that the semi-join's execution result is useless, the extra column should also be useless.

The outer join should be sufficient since it only applies if you have subquery predicate within a complex condition. @winoros : did not get your test suggestion. Is the subquery in the select list or where cluase? If where clause then it is already covered. Also, as far as the extra projection, prune columns is applied again at the end of the rules which removes the subquery result column.

ti-chi-bot · 2024-12-20T08:42:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [AilinKid,winoros]
~~pkg/planner/OWNERS~~ [AilinKid,winoros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-12-20T08:42:54Z

[LGTM Timeline notifier]

Timeline:

2024-12-20 02:48:31.543526011 +0000 UTC m=+1184301.632328553: ☑️ agreed by AilinKid.
2024-12-20 08:42:53.917563791 +0000 UTC m=+1205564.006366334: ☑️ agreed by winoros.

ghazalfamilyusa · 2024-12-20T17:46:24Z

/test check-dev2

ti-chi-bot · 2024-12-20T17:46:28Z

@ghazalfamilyusa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test pull-br-integration-test

/test pull-integration-ddl-test

/test pull-integration-e2e-test

/test pull-lightning-integration-test

/test pull-mysql-client-test

/test pull-unit-test-ddlv1

/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test

/test pull-common-test

/test pull-e2e-test

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-nodejs-test

/test pull-integration-python-orm-test

/test pull-scan-deps

/test pull-sqllogic-test

/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build

pingcap/tidb/ghpr_check

pingcap/tidb/ghpr_check2

pingcap/tidb/ghpr_mysql_test

pingcap/tidb/ghpr_unit_test

pingcap/tidb/pull_integration_ddl_test

pingcap/tidb/pull_integration_e2e_test

pingcap/tidb/pull_mysql_client_test

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2024-12-20T17:46:46Z

@ghazalfamilyusa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddlargsv1
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2024-12-20T17:46:48Z

@ti-chi-bot[bot]: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddlargsv1
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

In response to this:

@ghazalfamilyusa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-scan-deps
/test pull-sqllogic-test
/test pull-tiflash-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_mysql_client_test
In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ghazalfamilyusa · 2024-12-20T17:47:57Z

/test check-dev2

tiprow · 2024-12-20T17:48:18Z

@ghazalfamilyusa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddlargsv1
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 13, 2024

fixdb requested review from winoros and AilinKid December 13, 2024 23:09

ghazalfamilyusa force-pushed the subquery_predicate_simplification branch 2 times, most recently from ec1c904 to d5abe8f Compare December 14, 2024 00:15

ghazalfamilyusa changed the title ~~planner: extend predicate simplification for subquery and nested expressions~~ planner: extend predicate simplification for subquery and nested expressions | tidb-test=pr/2455 Dec 15, 2024

ghazalfamilyusa force-pushed the subquery_predicate_simplification branch from d5abe8f to 36205c6 Compare December 15, 2024 03:34

ghazalfamilyusa force-pushed the subquery_predicate_simplification branch 2 times, most recently from 239c407 to 25a3c4e Compare December 15, 2024 16:46

ghazalfamilyusa force-pushed the subquery_predicate_simplification branch from 25a3c4e to 5d0cce7 Compare December 15, 2024 22:40

ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 15, 2024

ghazalfamilyusa force-pushed the subquery_predicate_simplification branch from 5d0cce7 to ab1a796 Compare December 16, 2024 18:29

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Dec 17, 2024

AilinKid reviewed Dec 17, 2024

View reviewed changes

extend predicate simplification to cover: (1) Simplification of neste…

62d7858

…d AND/OR expressions with True/False values (2) Simplification of boolean expressions in subqueries

ghazalfamilyusa force-pushed the subquery_predicate_simplification branch from ab1a796 to 62d7858 Compare December 17, 2024 20:10

ghazalfamilyusa requested a review from AilinKid December 17, 2024 20:20

Merge branch 'master' into subquery_predicate_simplification

5b06b96

AilinKid reviewed Dec 19, 2024

View reviewed changes

ghazalfamilyusa requested a review from AilinKid December 19, 2024 19:25

AilinKid approved these changes Dec 20, 2024

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 20, 2024

winoros approved these changes Dec 20, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 20, 2024

ti-chi-bot bot merged commit e53ec59 into pingcap:master Dec 20, 2024
24 checks passed

yibin87 mentioned this pull request Dec 23, 2024

TiFlash daily test failed after PR 58261 due to resolveColumnIndex failure #58451

Open

xzhangxian1008 mentioned this pull request Dec 23, 2024

Randgen test fail with error "Can't find column Column#81 in schema Column: [] PKOrUK: [] NullableUK: []" #58454

Closed

yibin87 mentioned this pull request Dec 24, 2024

Tikv cop test failed after PR 58261 due to unexpected result. #58509

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

planner: extend predicate simplification for subquery and nested expressions | tidb-test=pr/2455 #58261

planner: extend predicate simplification for subquery and nested expressions | tidb-test=pr/2455 #58261

ghazalfamilyusa commented Dec 13, 2024

tiprow bot commented Dec 13, 2024

codecov bot commented Dec 15, 2024 •

edited

Loading

ghazalfamilyusa commented Dec 15, 2024

tiprow bot commented Dec 15, 2024

ghazalfamilyusa commented Dec 16, 2024

tiprow bot commented Dec 16, 2024

hawkingrei commented Dec 17, 2024

AilinKid Dec 17, 2024

AilinKid Dec 17, 2024

ghazalfamilyusa Dec 17, 2024 •

edited

Loading

AilinKid left a comment

ghazalfamilyusa commented Dec 17, 2024

ti-chi-bot bot commented Dec 17, 2024

tiprow bot commented Dec 17, 2024

ghazalfamilyusa commented Dec 17, 2024

ti-chi-bot bot commented Dec 17, 2024

tiprow bot commented Dec 17, 2024

ghazalfamilyusa commented Dec 17, 2024

ghazalfamilyusa commented Dec 17, 2024

tiprow bot commented Dec 17, 2024

ghazalfamilyusa commented Dec 19, 2024

tiprow bot commented Dec 19, 2024

AilinKid left a comment

AilinKid Dec 19, 2024

winoros Dec 19, 2024 •

edited

Loading

ghazalfamilyusa Dec 19, 2024

ti-chi-bot bot commented Dec 20, 2024

ti-chi-bot bot commented Dec 20, 2024

ghazalfamilyusa commented Dec 20, 2024

ti-chi-bot bot commented Dec 20, 2024

tiprow bot commented Dec 20, 2024

tiprow bot commented Dec 20, 2024

ghazalfamilyusa commented Dec 20, 2024

tiprow bot commented Dec 20, 2024

planner: extend predicate simplification for subquery and nested expressions | tidb-test=pr/2455 #58261

planner: extend predicate simplification for subquery and nested expressions | tidb-test=pr/2455 #58261

Conversation

ghazalfamilyusa commented Dec 13, 2024

What problem does this PR solve?

Problem Summary:

What changed and how does it work?

Check List

Release note

tiprow bot commented Dec 13, 2024

codecov bot commented Dec 15, 2024 • edited Loading

Codecov Report

ghazalfamilyusa commented Dec 15, 2024

tiprow bot commented Dec 15, 2024

ghazalfamilyusa commented Dec 16, 2024

tiprow bot commented Dec 16, 2024

hawkingrei commented Dec 17, 2024

AilinKid Dec 17, 2024

Choose a reason for hiding this comment

AilinKid Dec 17, 2024

Choose a reason for hiding this comment

ghazalfamilyusa Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

AilinKid left a comment

Choose a reason for hiding this comment

ghazalfamilyusa commented Dec 17, 2024

ti-chi-bot bot commented Dec 17, 2024

tiprow bot commented Dec 17, 2024

ghazalfamilyusa commented Dec 17, 2024

ti-chi-bot bot commented Dec 17, 2024

tiprow bot commented Dec 17, 2024

ghazalfamilyusa commented Dec 17, 2024

ghazalfamilyusa commented Dec 17, 2024

tiprow bot commented Dec 17, 2024

ghazalfamilyusa commented Dec 19, 2024

tiprow bot commented Dec 19, 2024

AilinKid left a comment

Choose a reason for hiding this comment

AilinKid Dec 19, 2024

Choose a reason for hiding this comment

winoros Dec 19, 2024 • edited Loading

Choose a reason for hiding this comment

ghazalfamilyusa Dec 19, 2024

Choose a reason for hiding this comment

ti-chi-bot bot commented Dec 20, 2024

ti-chi-bot bot commented Dec 20, 2024

[LGTM Timeline notifier]

ghazalfamilyusa commented Dec 20, 2024

ti-chi-bot bot commented Dec 20, 2024

tiprow bot commented Dec 20, 2024

tiprow bot commented Dec 20, 2024

ghazalfamilyusa commented Dec 20, 2024

tiprow bot commented Dec 20, 2024

codecov bot commented Dec 15, 2024 •

edited

Loading

ghazalfamilyusa Dec 17, 2024 •

edited

Loading

winoros Dec 19, 2024 •

edited

Loading