-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log: Add upgrade progress information to the logs #58246
Conversation
Signed-off-by: ystaticy <[email protected]>
Hi @ystaticy. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58246 +/- ##
================================================
+ Coverage 73.1646% 73.8558% +0.6911%
================================================
Files 1680 1681 +1
Lines 462997 466620 +3623
================================================
+ Hits 338750 344626 +5876
+ Misses 103434 101254 -2180
+ Partials 20813 20740 -73
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: ystaticy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ystaticy any test to cover this change?
Signed-off-by: ystaticy <[email protected]>
Signed-off-by: ystaticy <[email protected]>
@yudongusa I added a UT case,PTAL~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, benmeadowcroft, djshow832, tiancaiamao, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #58255
Problem Summary:
What changed and how does it work?
Print progress information during the upgrade process:
Check List
Tests
Upgrading TiDB from a lower version to a higher version, with upgrade version update. The following logs can be observed during the process:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.