Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttl: add integration test with random fault session for TTL #58110

Merged

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Dec 9, 2024

What problem does this PR solve?

Issue Number: close #58411

What changed and how does it work?

  1. Add two tests related to TTL. One of them is the test with randomly faulty session, which cannot execute the SQL.
  2. Fix the bug that the result of getSession is unexpected in some situation.
  3. Fix the bug that the last_job_finish_time is not in correct TZ when the job is cancelled.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 9, 2024
@YangKeao YangKeao force-pushed the add-fuzz-integration-test-for-ttl branch 2 times, most recently from 9f47fff to c943f3b Compare December 9, 2024 18:09
@YangKeao
Copy link
Member Author

YangKeao commented Dec 9, 2024

/hold

It's not stable yet.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 78.78788% with 7 lines in your changes missing coverage. Please review.

Project coverage is 73.7763%. Comparing base (1fa2955) to head (79f31de).
Report is 16 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58110        +/-   ##
================================================
+ Coverage   73.1670%   73.7763%   +0.6093%     
================================================
  Files          1680       1681         +1     
  Lines        463042     465389      +2347     
================================================
+ Hits         338794     343347      +4553     
+ Misses       103444     101327      -2117     
+ Partials      20804      20715        -89     
Flag Coverage Δ
integration 43.3164% <36.3636%> (?)
unit 72.4817% <78.7878%> (+0.1811%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 46.1289% <ø> (+0.1091%) ⬆️

@YangKeao YangKeao force-pushed the add-fuzz-integration-test-for-ttl branch from c943f3b to 9a6d3c6 Compare December 11, 2024 05:52
@YangKeao
Copy link
Member Author

ref #58166

@YangKeao YangKeao force-pushed the add-fuzz-integration-test-for-ttl branch from 9a6d3c6 to 9da37a7 Compare December 19, 2024 07:18
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 19, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 19, 2024
@YangKeao YangKeao force-pushed the add-fuzz-integration-test-for-ttl branch 2 times, most recently from e1807e3 to 1190c89 Compare December 19, 2024 08:28
@YangKeao YangKeao force-pushed the add-fuzz-integration-test-for-ttl branch from 1190c89 to c7c1628 Compare December 19, 2024 09:54
@YangKeao YangKeao force-pushed the add-fuzz-integration-test-for-ttl branch from c7c1628 to 79f31de Compare December 19, 2024 11:15
@YangKeao
Copy link
Member Author

/hold

wait for #58421

@YangKeao
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2024
@YangKeao
Copy link
Member Author

/retest

@YangKeao
Copy link
Member Author

/unhold

Copy link

ti-chi-bot bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 20, 2024
Copy link

ti-chi-bot bot commented Dec 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-19 07:41:49.820763887 +0000 UTC m=+1115499.909566428: ☑️ agreed by lcwangchao.
  • 2024-12-20 06:26:06.976901714 +0000 UTC m=+1197357.065704256: ☑️ agreed by wjhuang2016.

@ti-chi-bot ti-chi-bot bot merged commit d9749cd into pingcap:master Dec 20, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add fuzzy test for concurrent running TTL job manager
3 participants