Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix goroutine leak when exceed quota in hash agg #58078

Merged
merged 7 commits into from
Dec 23, 2024

Conversation

xzhangxian1008
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #58004

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 9, 2024
Copy link

tiprow bot commented Dec 9, 2024

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5887%. Comparing base (71e70af) to head (4b5e536).
Report is 110 commits behind head on master.

Current head 4b5e536 differs from pull request most recent head 02f7f1c

Please upload reports for the commit 02f7f1c to get more accurate results.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58078        +/-   ##
================================================
+ Coverage   73.1346%   73.5887%   +0.4541%     
================================================
  Files          1675       1683         +8     
  Lines        461810     470905      +9095     
================================================
+ Hits         337743     346533      +8790     
- Misses       103314     103363        +49     
- Partials      20753      21009       +256     
Flag Coverage Δ
integration 43.2419% <69.5652%> (?)
unit 72.3853% <100.0000%> (+0.1147%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.4518% <ø> (-0.5406%) ⬇️

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 9, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 13, 2024
@xzhangxian1008
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 17, 2024
@xzhangxian1008
Copy link
Contributor Author

/cc @XuHuaiyu

@ti-chi-bot ti-chi-bot bot requested a review from XuHuaiyu December 18, 2024 03:17
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2024
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wshwsh12, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 19, 2024
Copy link

ti-chi-bot bot commented Dec 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-13 08:20:09.835207683 +0000 UTC m=+599399.924010227: ☑️ agreed by wshwsh12.
  • 2024-12-19 07:02:42.507788087 +0000 UTC m=+1113152.596590630: ☑️ agreed by zimulala.

1 similar comment
Copy link

ti-chi-bot bot commented Dec 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-13 08:20:09.835207683 +0000 UTC m=+599399.924010227: ☑️ agreed by wshwsh12.
  • 2024-12-19 07:02:42.507788087 +0000 UTC m=+1113152.596590630: ☑️ agreed by zimulala.

Copy link

tiprow bot commented Dec 19, 2024

@xzhangxian1008: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 02f7f1c link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xzhangxian1008
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Dec 23, 2024

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xzhangxian1008
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2024
@ti-chi-bot ti-chi-bot bot merged commit 985609a into pingcap:master Dec 23, 2024
23 of 24 checks passed
@xzhangxian1008 xzhangxian1008 deleted the fix-58004 branch December 23, 2024 04:27
@xzhangxian1008
Copy link
Contributor Author

/cherrypick release-8.5

@ti-chi-bot
Copy link
Member

@xzhangxian1008: new pull request created to branch release-8.5: #58462.

In response to this:

/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregate goroutine leak when exceed quota
4 participants