Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: fix connection double close #53690

Merged
merged 5 commits into from
Aug 5, 2024
Merged

server: fix connection double close #53690

merged 5 commits into from
Aug 5, 2024

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented May 30, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #53689

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 30, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 30, 2024
@tiprow tiprow
Copy link

tiprow bot commented May 30, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 30, 2024
@jackysp jackysp marked this pull request as ready for review May 30, 2024 12:06
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2024
@codecov Codecov
Copy link

codecov bot commented May 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.5@d9c5bf6). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #53690   +/-   ##
================================================
  Coverage               ?   73.6471%           
================================================
  Files                  ?       1096           
  Lines                  ?     351670           
  Branches               ?          0           
================================================
  Hits                   ?     258995           
  Misses                 ?      76039           
  Partials               ?      16636

@jackysp
add test case
822d5de 
Signed-off-by: Jack Yu <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 30, 2024
jackysp added 2 commits May 30, 2024 21:11
@jackysp
remove missing changes
64a96dd 
Signed-off-by: Jack Yu <[email protected]>
@jackysp
once more
048d284 
Signed-off-by: Jack Yu <[email protected]>
@jackysp
fix bazel
ac227e4 
Signed-off-by: Jack Yu <[email protected]>
YangKeao
YangKeao approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤦

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 31, 2024
bb7133
bb7133 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 4, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-31 08:42:08.730026811 +0000 UTC m=+3025082.487162385: ☑️ agreed by YangKeao.
  • 2024-06-04 00:53:30.66013133 +0000 UTC m=+3342564.417266900: ☑️ agreed by bb7133.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 5, 2024
@Defined2014 Defined2014 added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Aug 5, 2024
@Defined2014
Copy link
Contributor

/retest

1 similar comment
@Defined2014
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 05a1ad3 into pingcap:release-6.5 Aug 5, 2024
10 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #55186.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 5, 2024
@jackysp @ti-chi-bot
This is an automated cherry-pick of pingcap#53690
a8023bf 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 5, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Aug 5, 2024
@ti-chi-bot
server: fix connection double close (#53690) (#55186)
b0823fa 
close #53689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

@bb7133 bb7133 bb7133 approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@CbcWestwolf CbcWestwolf Awaiting requested review from CbcWestwolf

Assignees
No one assigned
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jackysp @Defined2014 @ti-chi-bot @bb7133 @YangKeao