Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: extract functions and add comments #50773

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Jan 29, 2024

What problem does this PR solve?

Issue Number: ref #40791

Problem Summary:

What changed and how does it work?

  • Extracted some util functions.
  • Moved stats_table_row_cache out of cacher inner.
  • Add some comments.

No logic change, just some refactors.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Rustin170506 Rustin170506 added the skip-issue-check Indicates that a PR no need to check linked issue. label Jan 29, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 29, 2024
Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Merging #50773 (bd8d342) into master (1a0b7ff) will increase coverage by 2.6610%.
Report is 9 commits behind head on master.
The diff coverage is 88.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50773        +/-   ##
================================================
+ Coverage   70.4839%   73.1449%   +2.6610%     
================================================
  Files          1463       1464         +1     
  Lines        433198     437408      +4210     
================================================
+ Hits         305335     319942     +14607     
+ Misses       108629      97641     -10988     
- Partials      19234      19825       +591     
Flag Coverage Δ
integration 49.6997% <87.0000%> (?)
unit 70.8399% <85.0000%> (+0.5648%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.2940% <ø> (ø)
parser ∅ <ø> (∅)
br 51.2372% <ø> (+5.5227%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 29, 2024
@Rustin170506 Rustin170506 requested a review from qw4990 January 29, 2024 05:22
@hawkingrei hawkingrei requested a review from winoros January 29, 2024 06:11
Copy link

ti-chi-bot bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 30, 2024
Copy link

ti-chi-bot bot commented Jan 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-29 04:52:51.592825607 +0000 UTC m=+1368413.157123305: ☑️ agreed by hawkingrei.
  • 2024-01-30 02:12:47.937865002 +0000 UTC m=+1445209.502162706: ☑️ agreed by qw4990.

@Rustin170506 Rustin170506 removed the skip-issue-check Indicates that a PR no need to check linked issue. label Jan 30, 2024
@ti-chi-bot ti-chi-bot bot merged commit 25f44f5 into pingcap:master Jan 30, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants