planner: support pushing down predicates to memory tables in prepared mode (#40262) | tidb-test=pr/2145 #44718
+127
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/test mysql-test |
|
/test unit-test |
|
/test mysql-test |
djshow832
changed the title
|
/test mysql-test |
djshow832
changed the title
|
/test mysql-test |
xhebox
approved these changes
Jun 16, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #39605, cherry-pick from #40262
Problem Summary:
Predicates are not pushed down to memory tables in the prepared mode because the author avoids doing that intentionally. I'm not sure why but it should work.
What is changed and how it works?
Get the value from constant when it uses prepared mode. Note that it still skips evaluating when DeferredExpr is not nil.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.