Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: update the plan cache strategy when expressions with parameters affect null-check (#40218) #40476

Merged
merged 10 commits into from
Jan 17, 2023
Merged

planner: update the plan cache strategy when expressions with parameters affect null-check (#40218) #40476

merged 10 commits into from
Jan 17, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #40218

What problem does this PR solve?

Issue Number: close #40093, close #38205

Problem Summary: planner: update the plan cache strategy when expressions with parameters affect null-check

What is changed and how it works?

When expressions with parameters affect null-check, process null-check and skip plan-cache instead of skipping the null-check and caching a sub-optimal plan.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 10, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 10, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • chrysan
  • fzzf678

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added epic/plan-cache release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. do-not-merge/cherry-pick-not-approved labels Jan 10, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 10, 2023
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 10, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 10, 2023
@chrysan chrysan requested a review from qw4990 January 10, 2023 13:27
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 16, 2023
@qw4990
Copy link
Contributor

qw4990 commented Jan 16, 2023

/test unit-test

qw4990
qw4990 reviewed Jan 16, 2023
View reviewed changes
executor/stale_txn_test.go
@@ -533,19 +533,23 @@ func TestStalenessTransactionSchemaVer(t *testing.T) {
tk.MustExec("alter table t add c int")

// confirm schema changed
time.Sleep(time.Millisecond * 20)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the unstable test.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 16, 2023
@qw4990
Copy link
Contributor

qw4990 commented Jan 17, 2023

/test unit-test

@qw4990
Copy link
Contributor

qw4990 commented Jan 17, 2023

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: e673803

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 17, 2023
@ti-chi-bot ti-chi-bot merged commit 4504bc3 into pingcap:release-6.1 Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@fzzf678 fzzf678 fzzf678 approved these changes

@chrysan chrysan chrysan approved these changes

Assignees

@qw4990 qw4990

Labels
cherry-pick-approved Cherry pick PR approved by release team. epic/plan-cache release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-chi-bot @qw4990 @chrysan @fzzf678 @VelocityLight @Ivy-YinSu