-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore: set config value to default when failed to get config from tikv (#36051) #40254
restore: set config value to default when failed to get config from tikv (#36051) #40254
Conversation
Signed-off-by: Yu Juncen <[email protected]>
Signed-off-by: Yu Juncen <[email protected]>
Co-authored-by: 3pointer <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 67313b4
|
/hold high priority for trunk branch |
/unhold |
/retest |
/test check-dev2 |
/retest-required |
/test check-dev2 |
@3pointer: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #36051
Signed-off-by: Yu Juncen [email protected]
What problem does this PR solve?
Issue Number: close #36053
Problem Summary:
If we failed to get region size config from TiKV, we abort the restore procedure, which may not be robust.
What is changed and how it works?
Use the default config if the region size cannot be fetched from TiKV.
Check List
Tests
(TBD)
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.