-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: support compress for lightning, add compress unit and integration tests #39153
Changes from 18 commits
e0ed623
f4c9873
1fa5b1a
7a07c2d
39e30db
2238172
dab5dc5
90ab390
a23bf67
e55dd2a
536eac5
4c7eaf9
46ddf53
a3ce953
9a221d3
f64281f
369ab8a
a91ad73
c8a4817
aa1b841
9931544
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -134,7 +134,7 @@ func parseCompressionType(t string) (Compression, error) { | |
return CompressionGZ, nil | ||
case "lz4": | ||
return CompressionLZ4, nil | ||
case "zstd": | ||
case "zstd", "zst": | ||
return CompressionZStd, nil | ||
case "xz": | ||
return CompressionXZ, nil | ||
|
@@ -324,6 +324,9 @@ func (p regexRouterParser) Parse(r *config.FileRouteRule, logger log.Logger) (*R | |
if err != nil { | ||
return err | ||
} | ||
if result.Type == SourceTypeParquet && compression != CompressionNone { | ||
return errors.Errorf("can't support whole compressed parquet file, should compress parquet files by choosing correct parquet compress writer, path: %s", r.Path) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What does this workaround mean here? I remember we support compressed parquet files. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We support compressed binary data in parquet files, but we don't support compressed parquet files like |
||
} | ||
result.Compression = compression | ||
return nil | ||
}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does
INF
mean? infinite?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
INF
means infinite. It's used to make sure compressed files can be read until the EOF error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect to put its usage in the comment (as well as why this works, maybe)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in 46ddf53