Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM] upgrade grpc library to add grpc flow control config #3377

Closed
wants to merge 3 commits into from
Closed

[DNM] upgrade grpc library to add grpc flow control config #3377

wants to merge 3 commits into from

Conversation

hhkbp2
Copy link
Contributor

@hhkbp2 hhkbp2 commented Jun 3, 2017

Hi,

This PR upgrade grpc library to the version 3419b42955675df23457629c75f58eb8dcd56954, which has the interfaces

WithInitialWindowSize()
WithInitialConnWindowSize()

to config the flow control in grpc client.

PTAL @nolouch @siddontang @coocood @tiancaiamao @disksing

siddontang
siddontang reviewed Jun 3, 2017
View reviewed changes
store/tikv/client.go
@@ -32,6 +32,9 @@ const (
readTimeoutMedium = 60 * time.Second // For requests that may need scan region.
readTimeoutLong = 150 * time.Second // For requests that may need scan region multiple times.

grpcInitialWindowSize = 1 << 30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reference to use 1GB here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://blog.ayanamist.com/2015/12/25/http2%E7%9A%84%E6%B5%81%E6%8E%A7%E6%9C%BA%E5%88%B6.html

nolouch
nolouch reviewed Jun 3, 2017
View reviewed changes
glide.yaml
- package: google.golang.org/grpc
version: v1.2.1
version: 3419b42955675df23457629c75f58eb8dcd56954
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see etcd update grpc-gateway to 1.2.2 with grpc 1.3.x, maybe we can also update it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not a must, I prefer to take one small step at a time, and leave other upgrade to later PR.

@siddontang
Copy link
Member

LGTM

If etcd upgrades to grpc 1.3, we can do it later.

@coocood
Copy link
Member

coocood commented Jun 5, 2017

@hhkbp2
Can we upgrade after we merge grpc branch to master?
So the PR merges grpc to master won't be too large.

@hhkbp2
Copy link
Contributor Author

hhkbp2 commented Jun 5, 2017 •
edited
Loading

@coocood

Can we upgrade after we merge grpc branch to master?
So the PR merges grpc to master won't be too large.

Sure. Let's make two merges.

@hhkbp2
Copy link
Contributor Author

hhkbp2 commented Jun 5, 2017

Two new PRs will be raised after grpc enters master branch.

  1. upgrade the glide.yml
  2. add codes to configure the window size

This PR gonna be closed.

@hhkbp2 hhkbp2 closed this Jun 5, 2017
This was referenced Jun 5, 2017
Merged
Merged
@hhkbp2 hhkbp2 deleted the hhkbp2/grpc-upgrade-deps branch June 6, 2017 08:35
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
@gengliqi gengliqi mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch left review comments

@siddontang siddontang siddontang left review comments

Assignees
No one assigned
Labels
contribution This PR is from a community contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hhkbp2 @siddontang @coocood @nolouch @sre-bot