*: use etcd for privilege update notification #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PD already have etcd embed, take full use of it.
|
can you update vendor in another pr ? |
|
I'll rebase it after #3032 |
tiancaiamao
force-pushed
the
tiancaiamao/notify-update
branch
from
ff60b6e to
86ba2e2
Compare
zimulala
reviewed
Apr 11, 2017
domain/notify/notify.go
Outdated
| @@ -0,0 +1,34 @@ | |||
| // Copyright 2015 PingCAP, Inc. | |||
session.go
Outdated
| DialTimeout: 5 * time.Second, | ||
| }) | ||
| if err != nil { | ||
| return dom, errors.Trace(err) |
domain/domain.go
Outdated
| } | ||
| case <-do.exit: | ||
| return | ||
| // if etcd is available, notification i |
There was a problem hiding this comment.
Please complete this comment.
|
Do you forget to replace the |
|
We don't need to make a |
|
PTAL @coocood @hanfei1991 @zimulala |
|
LGTM |
coocood
previously approved these changes
Apr 11, 2017
zimulala
approved these changes
Apr 11, 2017
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PD already have etcd embed, take full use of it.