planner: do not cache prepared plan if optimization depends on mutable constant #22349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuyifangreeneyes
requested review from
XuHuaiyu
and removed request for
a team
|
/run-all-tests |
qw4990
requested review from
qw4990 and
eurekaka
and removed request for
XuHuaiyu
qw4990
added
needs-cherry-pick-4.0
sig/planner
qw4990
reviewed
Jan 11, 2021
| @@ -374,7 +374,7 @@ REBUILD: | |||
| e.names = names | |||
| e.Plan = p | |||
| _, isTableDual := p.(*PhysicalTableDual) | |||
| if !isTableDual && prepared.UseCache { | |||
| if !isTableDual && prepared.UseCache && !stmtCtx.OptimDependOnMutableConst { | |||
There was a problem hiding this comment.
Nice. It seems all places that use ContainMutableConst should be modified. We can only modify EvaluateExprWithNull in this PR and change all other places later in another PR.
|
PTAL @eurekaka |
Closed
|
/run-all-tests |
ti-srebot
approved these changes
Jan 12, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jan 12, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #22353 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jan 12, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-5.0-rc in PR #22354 |
ti-srebot
added a commit
that referenced
this pull request
Jan 25, 2021
…e constant (#22349) (#22353) Signed-off-by: ti-srebot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #22167
Problem Summary:
Incorrectly reuse cached plan which turns outer join to inner join.
What is changed and how it works?
What's Changed & How it Works:
EvaluateExprWithNullis used in several optimizations such as converting outer join to inner join. If the result ofEvaluateExprWithNulldepends on parameters of execute statement, whether the optimizations can be used is affected by the parameters. When optimizing a prepared plan, ifexprpassed intoEvaluateExprWithNullcontains mutable constant, we still do optimization but do not cache the plan.Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests a
Release note