Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshot infoschema should block GC #57952

Closed
tiancaiamao opened this issue Dec 3, 2024 · 4 comments · Fixed by #58062
Closed

snapshot infoschema should block GC #57952

tiancaiamao opened this issue Dec 3, 2024 · 4 comments · Fixed by #58062
Assignees
@tiancaiamao
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. priority/release-blocker This issue blocks a release. Please solve it ASAP. severity/critical sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@tiancaiamao
Copy link
Contributor

tiancaiamao commented Dec 3, 2024 •
edited
Loading

Enhancement

Currently, the meta package use old transaction API, unlike normal internal transaction, those APIs can not block the GC safepoint advancing (not updating min start ts).

This may cause "GC life time is shorter than transaction duration" error for InfoSchema V2.

Maybe a possible fix is collect the min start ts of all snapshot infoschemas.
@tiancaiamao tiancaiamao added the type/enhancement The issue or PR belongs to an enhancement. label Dec 3, 2024
@tiancaiamao tiancaiamao mentioned this issue Dec 3, 2024
Merged
13 tasks
@tiancaiamao
Copy link
Contributor Author

/cc @MyonKeminta

@tiancaiamao tiancaiamao self-assigned this Dec 3, 2024
@lance6716
Copy link
Contributor

maybe #57960 is also related? Maintaining minTS for GC should be designed at a proper layer, without these special handling of infoschema and analyze

@tiancaiamao
Copy link
Contributor Author

maybe #57960 is also related? Maintaining minTS for GC should be designed at a proper layer, without these special handling of infoschema and analyze

I'm not sure. We need to check the error stack to confirm it.

@Rustin170506
Copy link
Member

maybe #57960 is also related? Maintaining minTS for GC should be designed at a proper layer, without these special handling of infoschema and analyze

For internal sessions, we already did #32726 to improve it.

@wjhuang2016 wjhuang2016 added type/bug The issue is confirmed as a bug. severity/critical labels Dec 5, 2024
@wjhuang2016 wjhuang2016 added priority/release-blocker This issue blocks a release. Please solve it ASAP. and removed type/enhancement The issue or PR belongs to an enhancement. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 may-affects-8.1 labels Dec 5, 2024
@tiancaiamao tiancaiamao mentioned this issue Dec 6, 2024
Merged
13 tasks
@tiancaiamao tiancaiamao added affects-8.5 This bug affects the 8.5.x(LTS) versions. and removed may-affects-8.5 labels Dec 6, 2024
@jebter jebter added the sig/sql-infra SIG: SQL Infra label Dec 9, 2024
This was referenced Dec 9, 2024
Open
Closed
@ti-chi-bot ti-chi-bot bot closed this as completed in 0ffac36 Dec 9, 2024
@ti-chi-bot ti-chi-bot mentioned this issue Dec 9, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Dec 10, 2024
@ti-chi-bot
domain,infoschema: make infoschema activity block GC safepoint advanc…
1c79477 
…ing (#58062) (#58103)

close #57952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiancaiamao tiancaiamao

Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. priority/release-blocker This issue blocks a release. Please solve it ASAP. severity/critical sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

domain,infoschema: make infoschema activity block GC safepoint advancing tiancaiamao/tidb
5 participants
@tiancaiamao @lance6716 @jebter @wjhuang2016 @Rustin170506