Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: wait till info schema loading finished before proceeding to the rest of the PiTR restore #57743

Closed
Tristan1900 opened this issue Nov 26, 2024 · 0 comments · Fixed by #57742
Closed

br: wait till info schema loading finished before proceeding to the rest of the PiTR restore #57743

Tristan1900 opened this issue Nov 26, 2024 · 0 comments · Fixed by #57742
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/minor type/bug The issue is confirmed as a bug.

Comments

@Tristan1900
Copy link
Contributor

Tristan1900 commented Nov 26, 2024 •
edited
Loading

Bug Report

In a cluster with large number of tables but minimal actual data, during PiTR restore infoSchema can take minutes to load the restore change, and since actual data restore finished within seconds, restore process tries to use infoSchema for insertGCRow before its reloading finished, and it can cause problem of the below

[error="[domain:8027]Information schema is out of date: schema failed to update in 1 lease, please make sure TiDB can connect to TiKV"]
@Tristan1900 Tristan1900 added the type/bug The issue is confirmed as a bug. label Nov 26, 2024
@Tristan1900 Tristan1900 changed the title br: wait till info schema loading to finish before proceed to the rest of the PiTR restore br: wait till info schema loading finished before proceeding to the rest of the PiTR restore Nov 26, 2024
@Tristan1900 Tristan1900 mentioned this issue Nov 26, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added affects-8.5 This bug affects the 8.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. labels Nov 27, 2024
@jebter jebter added the component/br This issue is related to BR of TiDB. label Nov 29, 2024
ti-chi-bot bot pushed a commit that referenced this issue Dec 3, 2024
@Tristan1900
br: fix insert gc failed due to slow schema reload (#57742)
8fe0618 
close #57743
@ti-chi-bot ti-chi-bot mentioned this issue Dec 3, 2024
Merged
13 tasks
@BornChanger BornChanger mentioned this issue Dec 3, 2024
Merged
16 tasks
ti-chi-bot bot pushed a commit that referenced this issue Dec 3, 2024
@ti-chi-bot
br: fix insert gc failed due to slow schema reload (#57742) (#57907)
727b279 
close #57743
This was referenced Dec 6, 2024
Closed
Closed
Tristan1900 added a commit to Tristan1900/tidb that referenced this issue Dec 12, 2024
@Tristan1900
br: fix insert gc failed due to slow schema reload (pingcap#57742)
c79620b 
close pingcap#57743

(cherry picked from commit 8fe0618)
Tristan1900 added a commit to Tristan1900/tidb that referenced this issue Dec 12, 2024
@Tristan1900
br: fix insert gc failed due to slow schema reload (pingcap#57742)
c72c2a7 
close pingcap#57743

(cherry picked from commit 8fe0618)
@Tristan1900 Tristan1900 mentioned this issue Dec 12, 2024
Merged
13 tasks
Tristan1900 added a commit to Tristan1900/tidb that referenced this issue Dec 12, 2024
@Tristan1900
br: fix insert gc failed due to slow schema reload (pingcap#57742)
2e649aa 
close pingcap#57743

(cherry picked from commit 8fe0618)
Tristan1900 added a commit to Tristan1900/tidb that referenced this issue Dec 12, 2024
@Tristan1900
br: fix insert gc failed due to slow schema reload (pingcap#57742)
242a1ac 
close pingcap#57743

(cherry picked from commit 8fe0618)
@Tristan1900 Tristan1900 mentioned this issue Dec 12, 2024
Merged
13 tasks
Tristan1900 added a commit to Tristan1900/tidb that referenced this issue Dec 12, 2024
@Tristan1900
br: fix insert gc failed due to slow schema reload (pingcap#57742)
c11ab96 
close pingcap#57743

(cherry picked from commit 8fe0618)
Tristan1900 added a commit to Tristan1900/tidb that referenced this issue Dec 12, 2024
@Tristan1900
br: fix insert gc failed due to slow schema reload (pingcap#57742)
a256234 
close pingcap#57743

(cherry picked from commit 8fe0618)
@ti-chi-bot ti-chi-bot mentioned this issue Dec 17, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

br: fix insert gc failed due to slow schema reload Tristan1900/tidb
3 participants
@jebter @3pointer @Tristan1900