Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime Filter: Reduce useless logs #57625

Closed
elsa0520 opened this issue Nov 22, 2024 · 0 comments · Fixed by #57626
Closed

Runtime Filter: Reduce useless logs #57625

elsa0520 opened this issue Nov 22, 2024 · 0 comments · Fixed by #57626
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.

Comments

@elsa0520
Copy link
Contributor

elsa0520 commented Nov 22, 2024

Enhancement

Some logs info shows the message which meaning can be directly displayed by default behavior. So we don't need to addition log it.

For example, the runtime filter could not support the hash join which is running in TiDB. This is the default behavior of Runtime Filter. So when the planner meet the TiDB hash join, we don't need to log it by "RF only support TiFlash compute engine while storage type of hash join node is not TiFlash"

func (generator *RuntimeFilterGenerator) generateRuntimeFilterInterval(hashJoinPlan *PhysicalHashJoin) {
	// precondition: the storage type of hash join must be TiFlash
	if hashJoinPlan.storeTp != kv.TiFlash {
		logutil.BgLogger().Warn("RF only support TiFlash compute engine while storage type of hash join node is not TiFlash",
			zap.Int("PhysicalHashJoinId", hashJoinPlan.ID()),
			zap.String("StoreTP", hashJoinPlan.storeTp.Name()))
		return
	}
@elsa0520 elsa0520 added the type/enhancement The issue or PR belongs to an enhancement. label Nov 22, 2024
@elsa0520 elsa0520 added affects-8.5 This bug affects the 8.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. sig/planner SIG: Planner labels Nov 22, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in bc03ed8 Nov 22, 2024
winoros pushed a commit to winoros/tidb that referenced this issue Nov 26, 2024
ti-chi-bot bot pushed a commit that referenced this issue Nov 26, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this issue Nov 27, 2024
ti-chi-bot bot pushed a commit that referenced this issue Dec 23, 2024
@ti-chi-bot ti-chi-bot bot added the affects-7.5 This bug affects the 7.5.x(LTS) versions. label Dec 26, 2024
ti-chi-bot bot pushed a commit that referenced this issue Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
1 participant