Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel ADD INDEX job with DXF is slow #57325

Closed
CbcWestwolf opened this issue Nov 12, 2024 · 0 comments · Fixed by #57813
Closed

Cancel ADD INDEX job with DXF is slow #57325

CbcWestwolf opened this issue Nov 12, 2024 · 0 comments · Fixed by #57813
Assignees
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@CbcWestwolf
Copy link
Member

CbcWestwolf commented Nov 12, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. enable tidb_ddl_enable_fast_reorg and tidb_enable_dist_task
  2. set tidb_ddl_reorg_max_write_speed (introduced in ddl: introduce a new system variable to control the store-write-bwlimit when ingesting #57145) to a small speed like 1kb
  3. add index in session 1, which would cost some time
  4. cancel the add index job in session 2

2. What did you expect to see? (Required)

The job can be canceled in time

3. What did you see instead (Required)

It takes much time for the job state to transfer from 'canceling' to 'rollback done'

4. What is your TiDB version? (Required)

https://github.com/pingcap/tidb/tree/f973f194b21a8e79d42be3a9d4b2db441073f51c with #57145

@CbcWestwolf CbcWestwolf added type/bug The issue is confirmed as a bug. severity/major component/ddl This issue is related to DDL of TiDB. labels Nov 12, 2024
@CbcWestwolf CbcWestwolf self-assigned this Nov 12, 2024
@CbcWestwolf CbcWestwolf mentioned this issue Nov 18, 2024
13 tasks
@CbcWestwolf CbcWestwolf changed the title ADD INDEX job can not be canceled with DXF Cancel ADD INDEX job with DXF is slow Nov 21, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in 5753106 Nov 29, 2024
@tangenta tangenta added the affects-8.5 This bug affects the 8.5.x(LTS) versions. label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants