Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl ingest can not set store-write-bwlimit while using lightning local backend #57156

Closed
CbcWestwolf opened this issue Nov 6, 2024 · 0 comments · Fixed by #57145
Closed

ddl ingest can not set store-write-bwlimit while using lightning local backend #57156

CbcWestwolf opened this issue Nov 6, 2024 · 0 comments · Fixed by #57145
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@CbcWestwolf
Copy link
Member

We introduced a store write limiter in #35193 to reduce the impact on online services.
But we can not set this when adding index utilizes lightning local backend.
A new variable is needed to reduce the impact of ADD INDEX on online services
@CbcWestwolf CbcWestwolf added type/bug The issue is confirmed as a bug. severity/major affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. labels Nov 6, 2024
@ti-chi-bot ti-chi-bot bot added may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 labels Nov 6, 2024
@CbcWestwolf CbcWestwolf mentioned this issue Nov 6, 2024
Merged
13 tasks
@CbcWestwolf CbcWestwolf removed may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 labels Nov 12, 2024
ti-chi-bot bot pushed a commit that referenced this issue Nov 14, 2024
@CbcWestwolf
ddl: introduce a new system variable to control the `store-write-bwli…
50dcee7 
…mit` when ingesting (#57145)

close #57156
This was referenced Nov 14, 2024
Open
Open
Merged
Open
Merged
ti-chi-bot bot pushed a commit that referenced this issue Nov 19, 2024
@ti-chi-bot
ddl: introduce a new system variable to control the `store-write-bwli…
c104575 
…mit` when ingesting (#57145) (#57378)

close #57156
ti-chi-bot bot pushed a commit that referenced this issue Dec 11, 2024
@ti-chi-bot
ddl: introduce a new system variable to control the `store-write-bwli…
c0e0d45 
…mit` when ingesting (#57145) (#57376)

close #57156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
1 participant
@CbcWestwolf