Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br/stream: log status panics when encountering incompatible versions #56999

Closed
YuJuncen opened this issue Oct 30, 2024 · 0 comments · Fixed by #57002
Closed

br/stream: log status panics when encountering incompatible versions #56999

YuJuncen opened this issue Oct 30, 2024 · 0 comments · Fixed by #57002
Labels
affects-8.4 component/br This issue is related to BR of TiDB. impact/panic severity/major type/bug The issue is confirmed as a bug.

Comments

@YuJuncen
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. Start a nightly cluster.
  2. Run br log status.

2. What did you expect to see? (Required)

BR should fail with message "incompatible".

3. What did you see instead (Required)

BR paniced.

4. What is your TiDB version? (Required)

Master.

img_v3_02g5_004ee82f-f62d-40d7-b2a6-6051a3969ecg

NOTE: The error was omitted at https://github.com/pingcap/tidb/pull/56075/files#diff-82ee5900311f16cef9a19f0efdc01606af750a36a92365bc7ac68bfb010eef44R186
@YuJuncen YuJuncen added the type/bug The issue is confirmed as a bug. label Oct 30, 2024
@Leavrth Leavrth mentioned this issue Oct 30, 2024
Merged
13 tasks
@Leavrth Leavrth added severity/major component/br This issue is related to BR of TiDB. labels Oct 30, 2024
ti-chi-bot bot pushed a commit that referenced this issue Oct 30, 2024
@Leavrth
br: fix wrong error (#57002)
49c3eba 
ref #55870, close #56999
@ti-chi-bot ti-chi-bot mentioned this issue Oct 30, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 31, 2024
@ti-chi-bot
br: fix wrong error (#57002) (#57010)
3547038 
ref #55870, close #56999
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-8.4 component/br This issue is related to BR of TiDB. impact/panic severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

br: fix wrong error Leavrth/tidb
3 participants
@jebter @YuJuncen @Leavrth