Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TTL should force to kill the scan SQL when TTL job cancels #56511

Closed
lcwangchao opened this issue Oct 9, 2024 · 0 comments · Fixed by #56518
Closed

TTL should force to kill the scan SQL when TTL job cancels #56511

lcwangchao opened this issue Oct 9, 2024 · 0 comments · Fixed by #56518
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.4 report/customer Customers have encountered this bug. severity/moderate sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@lcwangchao
Copy link
Collaborator

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. create a TTL table and insert a big number of rows but none of these rows is expired.
  2. wait TTL job start
  3. cancel the TTL job by set @global.tidb_ttl_scan_worker_count = 0

2. What did you expect to see? (Required)

The scan SQL should be killed immediately.

3. What did you see instead (Required)

The TTL will wait for the SQL done even if the TTL job cancelled.

4. What is your TiDB version? (Required)
@lcwangchao lcwangchao added type/bug The issue is confirmed as a bug. sig/sql-infra SIG: SQL Infra severity/moderate labels Oct 9, 2024
This was referenced Oct 9, 2024
Closed
Merged
@lcwangchao lcwangchao added affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. labels Oct 10, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in e68c26a Oct 11, 2024
@lcwangchao lcwangchao added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. and removed needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Oct 11, 2024
This was referenced Oct 11, 2024
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Oct 12, 2024
@ti-chi-bot
ttl: force to kill SQL in scan task when canceling TTL job/task (#56518…
eb94765 
…) (#56576)

close #56511
ti-chi-bot bot pushed a commit that referenced this issue Oct 12, 2024
@ti-chi-bot
ttl: force to kill SQL in scan task when canceling TTL job/task (#56518…
b5c0f24 
…) (#56578)

close #56511
@ti-chi-bot ti-chi-bot bot added the report/customer Customers have encountered this bug. label Oct 15, 2024
ti-chi-bot bot pushed a commit that referenced this issue Oct 22, 2024
@ti-chi-bot
ttl: force to kill SQL in scan task when canceling TTL job/task (#56518…
54efcc6 
…) (#56577)

close #56511
@ti-chi-bot ti-chi-bot mentioned this issue Oct 29, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.4 report/customer Customers have encountered this bug. severity/moderate sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
1 participant
@lcwangchao