-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BR-restore should still perform checksum even when the schema checksum is missing #56373
Comments
Split off from #43007 (comment). Since that the table schema's crc64xor is just the sum of the table's data files, the schema checksum is redundant. BR restore could simply rely on the total of the file crc64xor. I suggest
|
/assign @Tristan1900 |
@BornChanger: GitHub didn't allow me to assign the following users: Tristan1900. Note that only pingcap members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
After this fixing this issue I feel like we need to adjust the semantics of the |
close pingcap#56373 (cherry picked from commit 4f047be)
close pingcap#56373 (cherry picked from commit 4f047be)
close pingcap#56373 (cherry picked from commit 4f047be)
close pingcap#56373 (cherry picked from commit 4f047be)
close pingcap#56373 (cherry picked from commit 4f047be)
close pingcap#56373 (cherry picked from commit 4f047be)
close pingcap#56373 (cherry picked from commit 4f047be)
Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
br backup full --checksum=0
br restore full --checksum=1
2. What did you expect to see? (Required)
BR restore compare the
ADMIN CHECKSUM
with the sum of crc64xor of all files, which are always computed inbr backup
regardless of original--checksum
.3. What did you see instead (Required)
BR restore does not compare the checksum because it used the Schema's crc64xor which are not populated without
--checksum=1
.4. What is your TiDB version? (Required)
v6.5 and above
The text was updated successfully, but these errors were encountered: