Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetLabelRules incorrectly returned all the region label rules #55188

Closed
JmPotato opened this issue Aug 5, 2024 · 0 comments · Fixed by #55189
Closed

GetLabelRules incorrectly returned all the region label rules #55188

JmPotato opened this issue Aug 5, 2024 · 0 comments · Fixed by #55189
Labels
affects-8.1 This bug affects the 8.1.x(LTS) versions. component/pd severity/critical type/bug The issue is confirmed as a bug.

Comments

@JmPotato
Copy link
Member

JmPotato commented Aug 5, 2024

Bug Report

https://github.com/pingcap/tidb/pull/48738/files#diff-051fd616da576bb20e1a1db0e250fda5daef59ab46f38c778e173b07e1f71d06R64 incorrectly used the interface to get all region label rules, resulting in the passed ruleIDs not being used correctly. This changed the behavior that may cause critical bugs.
@JmPotato JmPotato added the type/bug The issue is confirmed as a bug. label Aug 5, 2024
@ti-chi-bot ti-chi-bot added affects-8.1 This bug affects the 8.1.x(LTS) versions. and removed may-affects-8.1 labels Aug 5, 2024
@JmPotato JmPotato mentioned this issue Aug 5, 2024
Merged
3 tasks
@JmPotato JmPotato mentioned this issue Aug 5, 2024
Merged
ti-chi-bot bot pushed a commit to tikv/pd that referenced this issue Aug 5, 2024
@JmPotato
client/http: fix the URI of GetRegionLabelRulesByIDs (#8490)
838ee79 
close #8491, ref pingcap/tidb#55188

Fix the URI of `GetRegionLabelRulesByIDs` to correct the call.

Signed-off-by: JmPotato <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Aug 5, 2024
@JmPotato @ti-chi-bot
This is an automated cherry-pick of tikv#8490
456fa93 
close tikv#8491, ref pingcap/tidb#55188

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Aug 5, 2024
Merged
ti-chi-bot bot pushed a commit to tikv/pd that referenced this issue Aug 5, 2024
@ti-chi-bot @JmPotato
client/http: fix the URI of GetRegionLabelRulesByIDs (#8490) (#8493)
3d11c4d 
close #8491, ref pingcap/tidb#55188

Fix the URI of `GetRegionLabelRulesByIDs` to correct the call.

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: JmPotato <[email protected]>

Co-authored-by: JmPotato <[email protected]>
ti-chi-bot bot pushed a commit that referenced this issue Aug 5, 2024
@JmPotato
infosync: correct the PD API call of GetLabelRules (#55189)
6e03d23 
close #55188
@ti-chi-bot ti-chi-bot mentioned this issue Aug 5, 2024
Merged
3 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 5, 2024
@ti-chi-bot
infosync: correct the PD API call of GetLabelRules (#55189) (#55197)
891151b 
close #55188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-8.1 This bug affects the 8.1.x(LTS) versions. component/pd severity/critical type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

infosync: correct the PD API call of GetLabelRules JmPotato/tidb
4 participants
@JmPotato @jebter @Rustin170506 @ti-chi-bot