Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strictly checking column pruning would not cause empty column output for each operator #54777

Closed
winoros opened this issue Jul 19, 2024 · 1 comment · Fixed by #54778
Closed

Strictly checking column pruning would not cause empty column output for each operator #54777

winoros opened this issue Jul 19, 2024 · 1 comment · Fixed by #54778
Labels
sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.

Comments

@winoros
Copy link
Member

winoros commented Jul 19, 2024 •
edited
Loading

Enhancement

Zero column after column pruning is quite dangerous. We need to check it during our testing to avoid such cases.

TableDual is a special case. It's bonded with Projection. It only uses virtualRowNum.
@winoros winoros added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner labels Jul 19, 2024
@winoros
Copy link
Member Author

winoros commented Jul 19, 2024

Use intest to check it.

@winoros winoros mentioned this issue Jul 19, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in 60c7e61 Jul 29, 2024
hawkingrei pushed a commit to hawkingrei/tidb that referenced this issue Aug 1, 2024
@winoros @hawkingrei
planner: column pruning must reserve at least one column (pingcap#54778)
f0f47b1 
close pingcap#54777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

planner: column pruning must reserve at least one column winoros/tidb
1 participant
@winoros