Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple owner might exist at same time if keys are delete manually #54689

Closed
D3Hunter opened this issue Jul 17, 2024 · 0 comments · Fixed by #55692
Closed

multiple owner might exist at same time if keys are delete manually #54689

D3Hunter opened this issue Jul 17, 2024 · 0 comments · Fixed by #55692
Assignees
@joccau
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@D3Hunter
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  • 2 tidb
  • tidb1 become owner, but before it watch in here, the key is deleted, so it doesn't know it should retire

    tidb/pkg/owner/manager.go

    Line 449 in 2088b34

    watchCh := m.etcdCli.Watch(ctx, key)
  • tidb2 become owner

we should watch since the revision when we become owner to get notified

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master, and older version
@D3Hunter D3Hunter added the type/bug The issue is confirmed as a bug. label Jul 17, 2024
@jebter jebter added the component/ddl This issue is related to DDL of TiDB. label Jul 18, 2024
@D3Hunter D3Hunter added severity/moderate good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 20, 2024
@joccau joccau self-assigned this Aug 26, 2024
@joccau joccau mentioned this issue Aug 27, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in 0720ea8 Sep 4, 2024
@D3Hunter D3Hunter mentioned this issue Oct 29, 2024
Merged
13 tasks
@D3Hunter D3Hunter added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. labels Oct 31, 2024
This was referenced Oct 31, 2024
Merged
Merged
Open
Open
Merged
ti-chi-bot bot pushed a commit that referenced this issue Nov 4, 2024
@ti-chi-bot
ddl: watch the ddl ownerkey with the createRevision (#55692) (#57038)
4456391 
ref #54436, close #54689
ti-chi-bot bot pushed a commit that referenced this issue Dec 11, 2024
@ti-chi-bot
ddl: watch the ddl ownerkey with the createRevision (#55692) (#57039)
7ea2bd3 
ref #54436, close #54689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joccau joccau

Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ddl: watch the ddl ownerkey with the createRevision joccau/tidb
3 participants
@D3Hunter @jebter @joccau