Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dumpling: The logic for calculating file size is inaccurate #54624

Closed
shiyuhang0 opened this issue Jul 15, 2024 · 0 comments · Fixed by #54623
Closed

Dumpling: The logic for calculating file size is inaccurate #54624

shiyuhang0 opened this issue Jul 15, 2024 · 0 comments · Fixed by #54623
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@shiyuhang0
Copy link
Member

shiyuhang0 commented Jul 15, 2024 •
edited
Loading

Enhancement

This PR #32149 introduces CRLF as line-terminator and this PR #46983 introduces an option for line terminator.
Seems they all forgot to update the size of the line terminator here:

wp.currentFileSize += uint64(bf.Len()-lastBfSize) + 1 // 1 is for "\n"

I don't think it will impact the dumpling, but it is better to fix it, here is the PR:#54623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dumpling: fix the inaccurate calculation of file size in csv format writer shiyuhang0/tidb
1 participant
@shiyuhang0