Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction's memory usage is tracked multiple times #53984

Closed
ekexium opened this issue Jun 13, 2024 · 0 comments · Fixed by #53985
Closed

Transaction's memory usage is tracked multiple times #53984

ekexium opened this issue Jun 13, 2024 · 0 comments · Fixed by #53985
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.2 affects-7.3 affects-7.4 affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-7.6 affects-8.0 affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/moderate sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.

Comments

@ekexium
Copy link
Contributor

ekexium commented Jun 13, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

N/A

2. What did you expect to see? (Required)

Precise memory tracking.

3. What did you see instead (Required)

Transaction's memory usage is tracked by multiple times:

  1. MemDB tracker
  2. Stale tracking in executors like

    tidb/pkg/executor/replace.go

    Line 190 in 7b8c91d

    e.memTracker.Consume(int64(txn.Size() - txnSize))

4. What is your TiDB version? (Required)

master
@ekexium ekexium added type/bug The issue is confirmed as a bug. severity/moderate affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-6.6 affects-7.0 affects-7.2 affects-7.3 affects-7.4 affects-7.6 affects-8.0 labels Jun 13, 2024
@ekexium ekexium mentioned this issue Jun 13, 2024
Merged
13 tasks
@jebter jebter added the sig/transaction SIG:Transaction label Jun 13, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in 9960ae7 Jul 2, 2024
@ti-chi-bot ti-chi-bot mentioned this issue Jul 11, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jul 15, 2024
@ti-chi-bot
executor: do not track membuffer's memory in executor (#53985) (#54578)
d6d27e7 
close #53984
@ti-chi-bot ti-chi-bot mentioned this issue Jul 30, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jul 31, 2024
@ti-chi-bot
executor: do not track membuffer's memory in executor (#53985) (#55037)
2a0d7b8 
close #53984
@ti-chi-bot ti-chi-bot mentioned this issue Aug 23, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 27, 2024
@ti-chi-bot
executor: do not track membuffer's memory in executor (#53985) (#55627)
14a1cb0 
close #53984
@ti-chi-bot ti-chi-bot mentioned this issue Oct 28, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Nov 4, 2024
@ti-chi-bot
executor: do not track membuffer's memory in executor (#53985) (#56898)
8bb72c8 
close #53984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.2 affects-7.3 affects-7.4 affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-7.6 affects-8.0 affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/moderate sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor: do not track membuffer's memory in executor ekexium/tidb
2 participants
@jebter @ekexium