Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make channel frequently in the sortExec.Open #53866

Closed
Tracked by #52318
hawkingrei opened this issue Jun 7, 2024 · 1 comment · Fixed by #53881
Closed
Tracked by #52318

make channel frequently in the sortExec.Open #53866

hawkingrei opened this issue Jun 7, 2024 · 1 comment · Fixed by #53881
Assignees
@xzhangxian1008
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@hawkingrei
Copy link
Member

hawkingrei commented Jun 7, 2024 •
edited
Loading

Enhancement

sortExec.Open will make a channel every time. it will take too much time on it.

https://flamegraph.com/share/822c3df8-247d-11ef-ab1b-b6898751f631

img_v3_02bk_02cf8e47-9368-416d-9c30-c098fe80808g
@hawkingrei hawkingrei added the type/enhancement The issue or PR belongs to an enhancement. label Jun 7, 2024
@xzhangxian1008
Copy link
Contributor

/assign

@hawkingrei hawkingrei mentioned this issue Jun 7, 2024
Closed
5 tasks
@xzhangxian1008 xzhangxian1008 mentioned this issue Jun 7, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jun 11, 2024
@xzhangxian1008
executor: make channel buffer small in sort executor (#53881)
fedf3b7 
close #53866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xzhangxian1008 xzhangxian1008

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor: make channel buffer small in sort executor xzhangxian1008/tidb
2 participants
@hawkingrei @xzhangxian1008