Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nightly br always occurs oom where restore 1M tables #53529

Closed
shaoxiqian opened this issue May 24, 2024 · 2 comments · Fixed by #57192
Closed

nightly br always occurs oom where restore 1M tables #53529

shaoxiqian opened this issue May 24, 2024 · 2 comments · Fixed by #57192
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@shaoxiqian
Copy link
Contributor

br :nightly
br pod 6c16g
cluster 3tidb(16c) + 3tikv(16c) +1pd

100 thousands databases
more than 1M tables

command line:
GOMEMLIMIT=12GiB tiup br:nightly backup full --pd "pd-peer:2379" --storage "xxxx" --send-credentials-to-tikv=true --concurrency 256 --checksum=false --log-file backuptable-nightly-0523.log

occurs oom

Thu May 23 18:40:42 2024] oom-kill:constraint=CONSTRAINT_MEMCG,nodemask=(null),cpuset=cri-containerd-73a14efa3e7cd8784be29370e24d1a606722dfcfef7f6d738b91c1d161aa0843.scope,mems_allowed=0-1,oom_memcg=/kubepods.slice/kubepods-pode18246de_2b68_4d3b_8d67_a9857d24c513.slice,task_memcg=/kubepods.slice/kubepods-pode18246de_2b68_4d3b_8d67_a9857d24c513.slice/cri-containerd-73a14efa3e7cd8784be29370e24d1a606722dfcfef7f6d738b91c1d161aa0843.scope,task=br,pid=76630,uid=0
[Thu May 23 18:40:42 2024] Memory cgroup out of memory: Killed process 76630 (br) total-vm:22239
788kB, anon-rss:13884820kB, file-rss:0kB, shmem-rss:0kB, UID:0 pgtables:28052kB oom_score_adj:-997

Git Commit Hash: d1b8c5b
@shaoxiqian shaoxiqian added the type/bug The issue is confirmed as a bug. label May 24, 2024
@jebter jebter added component/br This issue is related to BR of TiDB. severity/major labels May 24, 2024
@BornChanger
Copy link
Contributor

Can you please get rid of the impact of other components? @shaoxiqian

@kennedy8312
Copy link

@shaoxiqian Hi, Xiqian, does the issue still occur in the latest code?

@ti-chi-bot ti-chi-bot bot added the affects-8.5 This bug affects the 8.5.x(LTS) versions. label Nov 1, 2024
@Leavrth Leavrth mentioned this issue Nov 7, 2024
Merged
13 tasks
@BornChanger BornChanger mentioned this issue Nov 7, 2024
Open
@ti-chi-bot ti-chi-bot bot closed this as completed in 5129bb3 Nov 13, 2024
@ti-chi-bot ti-chi-bot mentioned this issue Nov 13, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Nov 15, 2024
@ti-chi-bot
br: reduce memory usage when get incomplete ranges (#57192) (#57342)
6e6a012 
close #53529
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

br: reduce memory usage when get incomplete ranges Leavrth/tidb
5 participants
@jebter @Leavrth @shaoxiqian @kennedy8312 @BornChanger