Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl.BatchCreateTableWithInfo is different from ddl.CreateTableWithInfo #53374

Closed
Leavrth opened this issue May 20, 2024 · 0 comments · Fixed by #53465
Closed

ddl.BatchCreateTableWithInfo is different from ddl.CreateTableWithInfo #53374

Leavrth opened this issue May 20, 2024 · 0 comments · Fixed by #53465
Assignees
@tangenta
Labels
component/ddl This issue is related to DDL of TiDB. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@Leavrth
Copy link
Contributor

Leavrth commented May 20, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. BatchCreateTableWithInfo need to call d.callHookOnChanged at last if success.
  2. BatchCreateTableWithInfo need to handle the create sequence.
@Leavrth Leavrth added the type/bug The issue is confirmed as a bug. label May 20, 2024
@tangenta tangenta self-assigned this May 20, 2024
@tangenta tangenta mentioned this issue May 22, 2024
Merged
13 tasks
@jebter jebter added the component/ddl This issue is related to DDL of TiDB. label May 22, 2024
ti-chi-bot bot pushed a commit that referenced this issue May 28, 2024
@tangenta
ddl: support create sequences with BatchCreateTableWithInfo (#53465)
f7cea6c 
close #53374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tangenta tangenta

Labels
component/ddl This issue is related to DDL of TiDB. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ddl: support create sequences with BatchCreateTableWithInfo tangenta/tidb
3 participants
@jebter @tangenta @Leavrth