Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL_MODE not considered for VIEWs #53175

Closed
mjonss opened this issue May 10, 2024 · 1 comment · Fixed by #57473
Closed

SQL_MODE not considered for VIEWs #53175

mjonss opened this issue May 10, 2024 · 1 comment · Fixed by #57473
Assignees
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@mjonss
Copy link
Contributor

mjonss commented May 10, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

SQL_MODE is not used properly in views, like ONLY_FULL_GROUP_BY is not in effect.

See test case, where no warning is given for TiDB, while it is given for MySQL.

1. Minimal reproduce step (Required)

create table t (a int);
set @@sql_mode = default;
create view v as select * from t group by null;
select * from v;
set @@sql_mode = '';
select * from v;

2. What did you expect to see? (Required)

mysql> create table t (a int);
Query OK, 0 rows affected (0,02 sec)

mysql> set @@sql_mode = default;
Query OK, 0 rows affected (0,00 sec)

mysql> create view v as select * from t group by null;
Query OK, 0 rows affected (0,00 sec)

mysql> select * from v;
ERROR 1055 (42000): Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'test.t.a' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by
mysql> set @@sql_mode = '';
Query OK, 0 rows affected (0,00 sec)

mysql> select * from v;
Empty set (0,00 sec)

3. What did you see instead (Required)

tidb> create table t (a int);
Query OK, 0 rows affected (0.08 sec)

tidb> set @@sql_mode = default;
Query OK, 0 rows affected (0.00 sec)

tidb> create view v as select * from t group by null;
Query OK, 0 rows affected (0.10 sec)

tidb> select * from v;
Empty set (0.00 sec)

tidb> set @@sql_mode = '';
Query OK, 0 rows affected (0.01 sec)

tidb> select * from v;
Empty set (0.01 sec)

4. What is your TiDB version? (Required)

tidb_version(): Release Version: v8.0.0
Edition: Community
Git Commit Hash: 8ba1fa452b1ccdbfb85879ea94b9254aabba2916
Git Branch: HEAD
UTC Build Time: 2024-03-28 14:22:34
GoVersion: go1.21.6
Race Enabled: false
Check Table Before Drop: false
Store: tikv
@mjonss mjonss added the type/bug The issue is confirmed as a bug. label May 10, 2024
@ti-chi-bot ti-chi-bot bot added the affects-8.5 This bug affects the 8.5.x(LTS) versions. label Nov 1, 2024
@mjonss mjonss self-assigned this Nov 18, 2024
@mjonss mjonss added affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. and removed may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 may-affects-8.1 labels Nov 18, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in d0150c0 Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants