-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fast reorg checkpoint has wrong prerequisite #53009
Labels
affects-7.1
This bug affects the 7.1.x(LTS) versions.
affects-7.5
This bug affects the 7.5.x(LTS) versions.
affects-8.1
This bug affects the 8.1.x(LTS) versions.
component/ddl
This issue is related to DDL of TiDB.
severity/major
type/bug
The issue is confirmed as a bug.
Comments
ti-chi-bot
bot
added
may-affects-5.4
This bug maybe affects 5.4.x versions.
may-affects-6.1
may-affects-6.5
may-affects-7.1
may-affects-7.5
may-affects-8.1
labels
Apr 30, 2024
lance6716
added
affects-7.1
This bug affects the 7.1.x(LTS) versions.
affects-7.5
This bug affects the 7.5.x(LTS) versions.
affects-8.1
This bug affects the 8.1.x(LTS) versions.
labels
Apr 30, 2024
lance6716
removed
may-affects-5.4
This bug maybe affects 5.4.x versions.
may-affects-6.1
may-affects-6.5
labels
Apr 30, 2024
13 tasks
13 tasks
terry1purcell
pushed a commit
to terry1purcell/tidb
that referenced
this issue
May 17, 2024
RidRisR
pushed a commit
to RidRisR/tidb
that referenced
this issue
May 23, 2024
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects-7.1
This bug affects the 7.1.x(LTS) versions.
affects-7.5
This bug affects the 7.5.x(LTS) versions.
affects-8.1
This bug affects the 8.1.x(LTS) versions.
component/ddl
This issue is related to DDL of TiDB.
severity/major
type/bug
The issue is confirmed as a bug.
If the checkpoint record shows the it is generated by current node
tidb/pkg/ddl/ingest/checkpoint.go
Lines 307 to 308 in c24dca5
we skip the data whose key is smaller that "local storage key watermark" and assume the data is already stay in local storage.
tidb/pkg/ddl/ingest/checkpoint.go
Lines 128 to 137 in c24dca5
However this is not reliable, especially we are using
/tmp
folder to store the data https://docs.pingcap.com/tidb/stable/command-line-flags-for-tidb-configuration#--temp-dir. If the node restarts in many OS/tmp
folder will be cleaned.The text was updated successfully, but these errors were encountered: