Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use var_samp as window function cause unexpected error #52933

Closed
r33s3n6 opened this issue Apr 27, 2024 · 5 comments · Fixed by #53130
Closed

use var_samp as window function cause unexpected error #52933

r33s3n6 opened this issue Apr 27, 2024 · 5 comments · Fixed by #53130
Assignees
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.

Comments

@r33s3n6
Copy link

r33s3n6 commented Apr 27, 2024

Bug Report

When used with the OVER clause, var_samp functions as a window function. When there are non-aggregate columns present, it should not throw an error.
MySQL does not throw an error, and TiDB also does not throw errors for functions like var_pop and variance.

1. Minimal reproduce step (Required)

create table t1 (c1 int);
select c1, var_samp(c1) over (partition by c1) from t1;

2. What did you expect to see? (Required)

Empty set (0.00 sec)

3. What did you see instead (Required)

ERROR 8123 (HY000): In aggregated query without GROUP BY, expression #1 of SELECT list contains nonaggregated column 'c1'; this is incompatible with sql_mode=only_full_group_by

4. What is your TiDB version? (Required)

Release Version: v8.0.0
Edition: Community
Git Commit Hash: 8ba1fa452b1ccdbfb85879ea94b9254aabba2916
Git Branch: HEAD
UTC Build Time: 2024-03-28 14:22:15
GoVersion: go1.21.4
Race Enabled: false
Check Table Before Drop: false
Store: tikv
@yibin87
Copy link
Contributor

yibin87 commented Apr 29, 2024

Reproduced locally, and select c1, sum(c1) over (partition by c1) from t1;
According to MySQL doc: https://dev.mysql.com/doc/refman/8.0/en/aggregate-functions.html#function_var-samp:~:text=VAR_SAMP(expr,and%20Syntax%E2%80%9D., we should be aligned with MySQL.

@yibin87
Copy link
Contributor

yibin87 commented Apr 29, 2024

/label affects-8.1

@ti-chi-bot ti-chi-bot bot added affects-8.1 This bug affects the 8.1.x(LTS) versions. and removed may-affects-8.1 labels Apr 29, 2024
@yibin87
Copy link
Contributor

yibin87 commented May 6, 2024

This should be a planner issue, because it failed in planner phase.

@yibin87
Copy link
Contributor

yibin87 commented May 6, 2024

/remove-sig execution

@ti-chi-bot ti-chi-bot bot removed the sig/execution SIG execution label May 6, 2024
@yibin87
Copy link
Contributor

yibin87 commented May 6, 2024

/sig planner

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this issue May 15, 2024
terry1purcell pushed a commit to terry1purcell/tidb that referenced this issue May 17, 2024
RidRisR pushed a commit to RidRisR/tidb that referenced this issue May 23, 2024
@jebter jebter added the affects-6.5 This bug affects the 6.5.x(LTS) versions. label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants