Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BR compatible with InfoSchemaV2 #52717

Closed
Leavrth opened this issue Apr 18, 2024 · 0 comments · Fixed by #52718
Closed

BR compatible with InfoSchemaV2 #52717

Leavrth opened this issue Apr 18, 2024 · 0 comments · Fixed by #52718
Labels
component/br This issue is related to BR of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@Leavrth
Copy link
Contributor

Leavrth commented Apr 18, 2024 •
edited
Loading

Modification List

InfoSchema V2 feature issue: #50959

  1. Deprecate (*Meta).ListTables. It is called from br/pkg/stream/stream_mgr.go:buildObserveTableRanges to build log task ranges.
  2. Don't upload entire table infos when start a log backup task. Done by br: error if the log restore has no full backup schema or id maps #54421
  3. PITR restore and full restore checks whether there are user tables by calling GetExistedUserDBs. Switch to use a more efficient function.
  4. Use (infoschema.InfoSchema).SchemaTables to get system tables instead of DBInfo.Tables. It's OK because the number of system tables is very small.
  5. Maybe the cost of scanning the entire tables is very high, so IngestRecorder currently only search tables by table id of the recorded ingest index.
@Leavrth Leavrth added type/bug The issue is confirmed as a bug. severity/major component/br This issue is related to BR of TiDB. affects-8.1 This bug affects the 8.1.x(LTS) versions. labels Apr 18, 2024
@Leavrth Leavrth mentioned this issue Apr 18, 2024
Merged
13 tasks
@Leavrth Leavrth removed the affects-8.1 This bug affects the 8.1.x(LTS) versions. label Apr 22, 2024
ti-chi-bot bot pushed a commit that referenced this issue Jul 25, 2024
@Leavrth
br: make br compatible with infoschemaV2 (#52718)
1acb8f7 
close #52717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/br This issue is related to BR of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

br: make br compatible with infoschemaV2 Leavrth/tidb
1 participant
@Leavrth