Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize lightning conflict recording tables #52393

Closed
lyzx2001 opened this issue Apr 8, 2024 · 2 comments · Fixed by #53289
Closed

Optimize lightning conflict recording tables #52393

lyzx2001 opened this issue Apr 8, 2024 · 2 comments · Fixed by #53289
Assignees
@lyzx2001
Labels
affects-8.1 This bug affects the 8.1.x(LTS) versions. component/lightning This issue is related to Lightning of TiDB. type/enhancement The issue or PR belongs to an enhancement.

Comments

@lyzx2001
Copy link
Contributor

lyzx2001 commented Apr 8, 2024

Enhancement

Currently, conflicts from preprocess duplicate detection are stored in table lightning_task_info.conflict_records, conflicts from post-import conflict detection are stored in lightning_task_info.conflict_error_v2.
For better user experience, we would like to optimize them by using view to return the union of two tables, so that users do not need to search in two tables for conflicts.
@lyzx2001 lyzx2001 added the type/enhancement The issue or PR belongs to an enhancement. label Apr 8, 2024
@lyzx2001
Copy link
Contributor Author

lyzx2001 commented Apr 8, 2024

/assign @lyzx2001

This was referenced Apr 10, 2024
Merged
Closed
@lyzx2001
Copy link
Contributor Author

/label affects-8.1

@ti-chi-bot ti-chi-bot bot added the affects-8.1 This bug affects the 8.1.x(LTS) versions. label Apr 15, 2024
@ti-chi-bot ti-chi-bot mentioned this issue Apr 15, 2024
Merged
13 tasks
@jebter jebter added the component/lightning This issue is related to Lightning of TiDB. label Apr 29, 2024
@lyzx2001 lyzx2001 mentioned this issue May 15, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue May 21, 2024
@lyzx2001
lightning: provide view for users when using conflict detection (#53289)
67531d0 
close #52393
RidRisR pushed a commit to RidRisR/tidb that referenced this issue May 23, 2024
@lyzx2001 @RidRisR
lightning: provide view for users when using conflict detection (ping…
1939616 
…cap#53289)

close pingcap#52393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lyzx2001 lyzx2001

Labels
affects-8.1 This bug affects the 8.1.x(LTS) versions. component/lightning This issue is related to Lightning of TiDB. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lightning: provide view for users when using conflict detection lyzx2001/tidb
2 participants
@jebter @lyzx2001