Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NOT NULL flags for ExtraPhysTblIDColInfo #32881

Closed
mjonss opened this issue Mar 7, 2022 · 0 comments · Fixed by #32882
Closed

Add NOT NULL flags for ExtraPhysTblIDColInfo #32881

mjonss opened this issue Mar 7, 2022 · 0 comments · Fixed by #32882
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@mjonss
Copy link
Contributor

mjonss commented Mar 7, 2022

Enhancement

In #31634 an extra column info was added for getting the Physical Table ID as a column. That column cannot be NULL, but it is not marked as such in the colInfo.Flag.

So to make this more clear we should add mysql.NotNullFlag to that field in NewExtraPhysTblIDColInfo() (and also NewExtraPartitionIDColInfo()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

parser: Add not null flag for ExtraPhysTblIDColInfo and ExtraPartitionIDColInfo mjonss/tidb
1 participant
@mjonss