parser: Fix undocumented password_func function (#58312)

close #58311
pingcap · Dec 20, 2024 · 85b4656 · 85b4656
1 parent 27a9a7d
commit 85b4656
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/pkg/executor/reload_expr_pushdown_blacklist.go b/pkg/executor/reload_expr_pushdown_blacklist.go
@@ -315,7 +315,7 @@ var funcName2Alias = map[string]string{
 	"decode":                     ast.Decode,
 	"encode":                     ast.Encode,
 	"md5":                        ast.MD5,
-	"password_func":              ast.PasswordFunc,
+	"password":                   ast.PasswordFunc,
 	"random_bytes":               ast.RandomBytes,
 	"sha1":                       ast.SHA1,
 	"sha":                        ast.SHA,

diff --git a/pkg/expression/function_traits_test.go b/pkg/expression/function_traits_test.go
@@ -202,7 +202,7 @@ func TestIllegalFunctions4GeneratedColumns(t *testing.T) {
 		"octet_length",
 		"or",
 		"ord",
-		"password_func",
+		"password",
 		"period_add",
 		"period_diff",
 		"pi",

diff --git a/pkg/parser/ast/functions.go b/pkg/parser/ast/functions.go
@@ -312,7 +312,7 @@ const (
 	Decode                   = "decode"
 	Encode                   = "encode"
 	MD5                      = "md5"
-	PasswordFunc             = "password_func"
+	PasswordFunc             = "password"
 	RandomBytes              = "random_bytes"
 	SHA1                     = "sha1"
 	SHA                      = "sha"

diff --git a/pkg/parser/parser_test.go b/pkg/parser/parser_test.go
@@ -2254,7 +2254,7 @@ func TestBuiltin(t *testing.T) {
 		{`SELECT ENCRYPT('hello'), ENCRYPT('hello', @salt);`, true, "SELECT ENCRYPT(_UTF8MB4'hello'),ENCRYPT(_UTF8MB4'hello', @`salt`)"},
 		{`SELECT MD5('testing');`, true, "SELECT MD5(_UTF8MB4'testing')"},
 		{`SELECT OLD_PASSWORD(@str);`, true, "SELECT OLD_PASSWORD(@`str`)"},
-		{`SELECT PASSWORD(@str);`, true, "SELECT PASSWORD_FUNC(@`str`)"},
+		{`SELECT PASSWORD(@str);`, true, "SELECT PASSWORD(@`str`)"},
 		{`SELECT RANDOM_BYTES(@len);`, true, "SELECT RANDOM_BYTES(@`len`)"},
 		{`SELECT SHA1('abc');`, true, "SELECT SHA1(_UTF8MB4'abc')"},
 		{`SELECT SHA('abc');`, true, "SELECT SHA(_UTF8MB4'abc')"},

diff --git a/tests/integrationtest/r/executor/show.result b/tests/integrationtest/r/executor/show.result
@@ -773,7 +773,7 @@ oct
 octet_length
 or
 ord
-password_func
+password
 period_add
 period_diff
 pi