Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Add more log and compress option #202

Merged
merged 8 commits into from
Nov 20, 2020
Merged

Add more log and compress option #202

merged 8 commits into from
Nov 20, 2020

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Nov 20, 2020 •
edited
Loading

What problem does this PR solve?

dumpling needs to provide users more progress info and metrics while and after dumping.

What is changed and how it works?

  1. Add more status log
  2. Add --compress option
  3. Add Prometheus handler

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

  • support --compress option

@lichunzhu lichunzhu marked this pull request as ready for review November 20, 2020 07:08
@lichunzhu lichunzhu requested a review from kennytm November 20, 2020 07:09
kennytm
kennytm reviewed Nov 20, 2020
View reviewed changes
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

v4/export/config.go Outdated Show resolved Hide resolved
@lichunzhu lichunzhu merged commit 4f69a92 into pingcap:master Nov 20, 2020
@lichunzhu lichunzhu deleted the addMoreLogAndCompressOption branch November 20, 2020 09:46
@lichunzhu lichunzhu linked an issue Dec 14, 2020 that may be closed by this pull request
Support output compression #7
Closed
This was referenced Oct 14, 2021
Merged
Open
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
@lichunzhu
Add more log and compress option (pingcap#202)
c768eeb 
* add percentage log
* add summary
* redirect log to dumpling's logger
* add --compress option and relative integration test
* add prometheus metrics in dumpling
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
@lichunzhu
Add more log and compress option (pingcap#202)
a787c34 
* add percentage log
* add summary
* redirect log to dumpling's logger
* add --compress option and relative integration test
* add prometheus metrics in dumpling
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
@lichunzhu
Add more log and compress option (pingcap#202)
68d86e9 
* add percentage log
* add summary
* redirect log to dumpling's logger
* add --compress option and relative integration test
* add prometheus metrics in dumpling
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
@lichunzhu
Add more log and compress option (pingcap#202)
e1e013c 
* add percentage log
* add summary
* redirect log to dumpling's logger
* add --compress option and relative integration test
* add prometheus metrics in dumpling
tisonkun pushed a commit to tisonkun/tidb that referenced this pull request Oct 20, 2021
@lichunzhu @tisonkun
Add more log and compress option (pingcap/dumpling#202)
4d96936 
* add percentage log
* add summary
* redirect log to dumpling's logger
* add --compress option and relative integration test
* add prometheus metrics in dumpling
This was referenced Mar 24, 2022
Merged
Merged
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennytm kennytm kennytm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support output compression
2 participants
@lichunzhu @kennytm