-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MySQL compatibility #80
Conversation
# Conflicts: # src/ActivityStore/MariaDb.php
Great, thank you! We will take a look at it in detail. One question: if we do not change the database structure the mysql JSON search/filter possibilities will not work, correct? Wouldn't it be better to create a new/separate table for the mysql store which supports the JSON datatype? |
I am not sure which functionality you exactly mean. Could you point me to the code in the current master branch? Then I could look for the pendant in this PR (or say if it is missing). |
This functionality is not directly used within the bundle itself but could be used for example by segment builders (or other tools) to filter the activities table based on attributes within the "attributes" column. For example:
The JSON datatype supports similiar functionallities: But I think this will only work if it is actually a JSON field. |
Yes, with the current database structure you can use |
from my point of view 5.7 would be fine ... since aws aurora also supports 5.7 |
…mework # Conflicts: # src/Listing/Filter/Permission.php
…oted multiple times when inserted in the database
@fashxp any chance to merge this so we can use MySQL instead of MariaDB with the customer data framework? |
we discussed our next steps internally. |
@BlackbitNeueMedien are you done and have you tested the mysql store? did you also regression-test the mariadb store? |
Yes, we run this fork on 2 productive projects and have not noticed any problems. |
@fashxp can this be merged with the next cmf release? |
This PR provides JSON support to store activity data instead of MariaDB's dynamic columns. Whether MySQL or MariaDB shall be used can be configured in services.yml (change CustomerManagementFrameworkBundle\ActivityStore\ActivityStoreInterface to CustomerManagementFrameworkBundle\ActivityStore\MySQL).
For compatibility reasons it does not use JSON column type but keeps database structure untouched.
Solves #58