Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processes not handled properly if ps command not present #13

Closed
rubiesonthesky opened this issue Oct 29, 2021 · 1 comment
Closed

Processes not handled properly if ps command not present #13

rubiesonthesky opened this issue Oct 29, 2021 · 1 comment

Comments

@rubiesonthesky
Copy link

This concers exiftool-vendored usage but the problem is coming from this library.

When using exiftool-vendored in minimized Docker image, for example, Debian slim, processed are not killed / terminated correctly because ps command is not found. procps is not by default installed on slim version.

  1. Is there any way to add support for systems that do not have access to ps command? Propably unlikely.
  2. Could there be some warning printed or debug command to check if ps is missing?
  3. Could this requirement be documented clearly here and other libraries that are using this library, namely exiftool-vendored?

I'm sure I will not be only one having this issue where processes are just spawned with every task invocation and then reported "dead" because this library can't get their pid. Using minimized / slim Docker images is the recommendation and you wouldn't think that using node library is depending having ps command available :) After adding procps to my Docker image, things are working as they should be / same manner as my local dev environment.

@mceachen
Copy link
Member

mceachen commented Oct 29, 2021

Interesting: I've always run this in a docker container that had installed procps. TBH, I'd never even considered ps not being available on a POSIX system!

I'll put a warning on this package and exiftool-vendored for now. If you want to take a stab at a PR, we can reopen this issue and I'd be happy to review it.

mceachen added a commit that referenced this issue Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants