Create local puro path only when install

phntmxyz · Jun 12, 2024 · 41326d9 · 41326d9
1 parent 9f24106
commit 41326d9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/lib/src/install_puro.dart b/lib/src/install_puro.dart
@@ -66,7 +66,7 @@ Directory installPuroStandalone(String version, dcli.Progress? progress) {
   final puroLinuxDownloadUrl = "https://puro.dev/builds/$version/linux-x64/puro";
 
   int resultCode = -1;
-  final downloadPath = getPuroStandaloneBinPath();
+  final downloadPath = getPuroStandaloneBinPath(createIfNotExists: true);
   if (Platform.isWindows) {
     resultCode = installPuroStandaloneWindows(puroWindowsDownloadUrl, downloadPath, progress);
   } else if (Platform.isMacOS) {

diff --git a/lib/src/puro.dart b/lib/src/puro.dart
@@ -44,20 +44,22 @@ File? getPuroPath() {
     path = which.path;
   }
   if (path == null) {
-    final result = dcli.find('puro', workingDirectory: getPuroStandaloneBinPath().path, recursive: false);
-    path = result.firstLine;
+    final standalonePath = getPuroStandaloneBinPath();
+    if (standalonePath.existsSync()) {
+      final result = dcli.find('puro', workingDirectory: standalonePath.path, recursive: false);
+      path = result.firstLine;
+    }
   }
   return path != null ? File(path) : null;
 }
 
-Directory getPuroStandaloneBinPath() {
-  final installDir = Directory("${SidekickContext.sidekickPackage.buildDir.absolute.path}/puro");
-
-  final puroPath = '${installDir.path}/bin/';
-  if (!dcli.exists(puroPath)) {
-    dcli.createDir(puroPath, recursive: true);
+/// Returns the puro standalone bin path. It may not exist.
+Directory getPuroStandaloneBinPath({bool createIfNotExists = false}) {
+  final path = Directory("${SidekickContext.sidekickPackage.buildDir.absolute.path}/puro/bin/");
+  if (createIfNotExists && !path.existsSync()) {
+    path.createSync(recursive: true);
   }
-  return Directory(puroPath);
+  return path;
 }
 
 /// Thrown when puro is not found