Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: Delete to delete a documents from a collection #63

Merged
merged 3 commits into from
Apr 22, 2024
Merged

add: Delete to delete a documents from a collection #63

merged 3 commits into from
Apr 22, 2024

Conversation

iwilltry42
Copy link
Contributor

@iwilltry42 iwilltry42 commented Apr 19, 2024 •
edited
Loading

Hey there!

First off: This is the only embedded VectorDB I found for Go.. and it works really well - great work! 🙏

This PR adds the Delete function to delete a single document from a collection, similar to ChromaDB's collection.Delete()

Upstream reference: https://github.com/chroma-core/chroma/blob/ce5c6b35e7ee7b2786eec6e3f5e7c821fb30d844/chromadb/api/segment.py#L581-L646

philippgille
philippgille reviewed Apr 21, 2024
View reviewed changes
Copy link
Owner

@philippgille philippgille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only embedded VectorDB I found for Go.. and it works really well - great work! 🙏

Thank you so much for the kind words! And also for submitting the PR 👍

collection.go Outdated Show resolved Hide resolved
collection_test.go Outdated Show resolved Hide resolved
@iwilltry42
Copy link
Contributor Author

Thanks for the review @philippgille - I'll update the PR to reflect all params of https://docs.trychroma.com/reference/Collection#delete 👍

@philippgille philippgille mentioned this pull request Apr 22, 2024
Merged
@iwilltry42 iwilltry42 requested a review from philippgille April 22, 2024 18:06
philippgille
philippgille reviewed Apr 22, 2024
View reviewed changes
Copy link
Owner

@philippgille philippgille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing such an extensive test covering the different cases! 👍

collection.go Show resolved Hide resolved
@iwilltry42 iwilltry42 force-pushed the feat/delete-document branch from 59cfc55 to 1da54cf Compare April 22, 2024 19:09
@iwilltry42
Copy link
Contributor Author

Rebased on top of main ✔️

@iwilltry42 iwilltry42 requested a review from philippgille April 22, 2024 19:10
@iwilltry42 iwilltry42 changed the title add: DeleteDocument to delete a single document from a collection add: Delete to delete a single document from a collection Apr 22, 2024
@iwilltry42 iwilltry42 changed the title add: Delete to delete a single document from a collection add: Delete to delete a documents from a collection Apr 22, 2024
@philippgille philippgille merged commit df6c863 into philippgille:main Apr 22, 2024
4 checks passed
@philippgille
Copy link
Owner

Thanks again for your contribution! 🙇‍♂️

@iwilltry42 iwilltry42 deleted the feat/delete-document branch April 26, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippgille philippgille philippgille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iwilltry42 @philippgille