Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cohere embedding provider #61

Merged
merged 6 commits into from
Mar 23, 2024
Merged

Conversation

philippgille
Copy link
Owner

They need an "input type" prefix, which makes using it a bit clunky with the existing chromem.EmbeddingFunc. We should think about ways to improve this in the future.

To be consistent with the others
To be consistent with the model constants
- External: So users don't have to cast between the "enum" type and string
- Internal: So we don't have to add the colon and space each time
@philippgille philippgille merged commit f971ad9 into main Mar 23, 2024
2 checks passed
@philippgille philippgille deleted the add-cohere-embedding-provider branch March 23, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant