Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion failed: x should be a finite number #107

Open
zepumph opened this issue Dec 20, 2024 · 1 comment
Open

Assertion failed: x should be a finite number #107

zepumph opened this issue Dec 20, 2024 · 1 comment

Comments

@zepumph
Copy link
Member

zepumph commented Dec 20, 2024

From https://github.com/phetsims/phet-io/issues/2003

proportion-playground : phet-io-multi-fuzz : unbuilt
URL: http://128.138.93.172/continuous-testing/ct-snapshots/1734705712365/phet-io-wrappers/multi/?sim=proportion-playground&locales=*&phetioWrapperDebug=true&fuzz&phetioDebug=true&wrapperContinuousTest=%7B%22test%22%3A%5B%22proportion-playground%22%2C%22phet-io-multi-fuzz%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1734705712365%22%2C%22timestamp%22%3A1734708682118%7D
ERROR: Uncaught Error: Assertion failed: x should be a finite number
STACK: Error: Assertion failed: x should be a finite number
    at window.assertions.assertFunction (http://128.138.93.172/continuous-testing/ct-snapshots/1734705712365/assert/js/assert.js:45:21)
    at assert (../../../../../../scenery/js/nodes/Node.ts:2456:16)
    at translate (../../../../../../scenery/js/nodes/Node.ts:3115:11)
    at setCenterX (../../../../../../scenery/js/nodes/Node.ts:3125:9)
    at  (../../../../../../../proportion-playground/js/common/view/SceneNode.js:151:34)
    at updateControlButton (../../../../../../../../proportion-playground/js/common/view/paint/PaintSceneNode.js:77:11)
    at listener (../../../../../axon/js/TinyEmitter.ts:213:6)
    at notifyLoop (../../../../../axon/js/TinyEmitter.ts:185:17)
    at emit (../../../../../axon/js/ReadOnlyProperty.ts:344:22)
    at _notifyListeners (../../../../../axon/js/ReadOnlyProperty.ts:288:13)
    at unguardedSet (../../../../../axon/js/ReadOnlyProperty.ts:268:11)
    at set (../../../../../axon/js/Property.ts:54:10)
    at  (../../../../../sun/js/ToggleSwitch.ts:245:20)
    at apply (../../../../../tandem/js/PhetioAction.ts:162:16)
    at execute (../../../../../sun/js/ToggleSwitch.ts:332:23)
    at _end (../../../../../../scenery/js/listeners/DragListener.ts:352:24)
    at callback (../../../../../../scenery/js/listeners/PressListener.ts:766:16)
    at apply (../../../../../tandem/js/PhetioAction.ts:162:16)
    at execute (../../../../../../scenery/js/listeners/PressListener.ts:519:24)
    at release (../../../../../../scenery/js/listeners/DragListener.ts:348:10)
@zepumph
Copy link
Member Author

zepumph commented Dec 20, 2024

This commit is not actually a solution, but it gets us started. We need to layout the reveal button recognizing that PhET-iO can potentially hide all number pickers.

To Reproduce buggy layout:

  1. Go to studio
  2. First screen, second scene (colors)
  3. toggle to two splotches (4 pickers)
  4. Hide the two on the left
  5. Toggle back to one splotch (buggy reveal button layout)
  6. Show one of the pickers again on the left side (overlap with reveal button).
  • We may also want to just use dynamic layout, instead of actually solving this specific problem. That is why I'm spending too much time solving this well.

zepumph added a commit that referenced this issue Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant